[Adduser-devel] Bug#130751: Re: config-file checking for adduser/deluser

[Marc Haber]

tags #130751 wontfix
thanks

On Wed, Mar 24, 2004 at 12:33:10PM +0100, Marc Haber wrote:
> On Wed, Feb 13, 2002 at 04:16:02PM +1100, Peter Moulder wrote:
> > Attached is a patch against adduser_3.45.  The patch does what it set
> > out to do (add checking of config file), though I haven't yet done
> > proper testing (deluser especially), and the list of changes below
> > may be incomplete.
> 
> Wow, that's a huge patch, thanks for the work. I'd be, however,
> reluctant in applying it.
> 
> > Do validation of config file.
> 
> Good.
> 
> > "use strict;" everywhere.  Seems appropriate for script run as root.
> 
> Good. The script should use -w, and probably -T additionally.
> 
> > Use prototypes for all "normal" subs.
> 
> I don't like this. Prototypes in perl don't do as much as prototypes
> in C, and the perl wizards usually discourage use of prototypes.
> 
> I am not a perl wizard, so try to convince me of the opposite.

The submitter has not reacted to this message in over a year. I am
therefore tagging this bug wontfix - this is material for adduser 2.0.

Greetings
Marc

-- 
Marc.Haber@syscovery.com              syscovery network services GmbH
Dipl.-Inform.                                    Weinheimer Straße 68
Geschäftsführer                                      D-68309 Mannheim
Tel: +49 [0] 621 71768 57                   http://www.syscovery.com/