[Adduser-devel] Bug#231809: marked as done (adduser: deluser should check for mountpoints in $HOME)

Debian Bug Tracking System owner@bugs.debian.org
Fri, 06 May 2005 05:33:16 -0700

Your message dated Fri, 6 May 2005 14:21:10 +0200
with message-id <20050506122110.GA17295@lefler.int.l21.ma.zugschlus.de>
and subject line Closing bugs
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

Received: (at submit) by bugs.debian.org; 9 Feb 2004 00:25:26 +0000
>From pc@rocket.homelinux.org Sun Feb 08 16:25:26 2004
Return-path: <pc@rocket.homelinux.org>
Received: from p213.54.97.7.tisdip.tiscali.de (stralsunder-10.homelinux.org) [] (postfix)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1ApzEs-0000PL-00; Sun, 08 Feb 2004 16:25:26 -0800
Received: from rocket.homelinux.org (rocket [])
	by stralsunder-10.homelinux.org (Postfix) with ESMTP
	id B2D1125EDA9; Mon,  9 Feb 2004 01:25:23 +0100 (CET)
Received: by rocket.homelinux.org (Postfix, from userid 1000)
	id 7C2211740CA; Mon,  9 Feb 2004 01:26:06 +0100 (CET)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Andreas Schmidt <pi.c@tiscali.de>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: adduser: deluser should check for mountpoints in $HOME
X-Mailer: reportbug 2.43
Date: Mon, 09 Feb 2004 01:26:06 +0100
Message-Id: <20040209002606.7C2211740CA@rocket.homelinux.org>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_02_01 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=HAS_PACKAGE autolearn=no 

Package: adduser
Version: 3.47
Severity: critical
Justification: causes serious data loss

With kernel 2.4 and higher, one can use constructs such as
	mount --bind /mnt/ftp/pub /home/user1/ftproot

I used that with proftpd to make files from different partitions
available to users inside their home. Just some minutes ago I managed to
wipe the mounted dir by doing a 
	deluser --remove-home
without the backup option installed and forgetting to umount the dir.

Of course, I should have been more careful. But it would have been
helpful if deluser had checked for mounted dirs in the user's home. A
simple "mount | grep $HOME" would be enough to issue a warning and
prompt for removal of each mounted dir. 

/usr/local/sbin/adduser.local can be used to modify the local setup
after a user has been created. I used this file to mount the dir. 
The same thing exists for deluser (/usr/local/sbin/deluser.local). While
it makes perfectly sense for adduser to allow only post-modification,
that is not enough for deluser. An additional file that gets executed
_before_ the actual removal of the user could be useful to ensure mounts
in the user's home get umounted before any harm is done.

-- System Information:
Debian Release: stable
  APT prefers stable
Architecture: i386 (i686)
Kernel: Linux 2.4.24
Locale: LANG=en_US.ISO-8859-1, LC_CTYPE=de_DE@euro

Received: (at 231809-done) by bugs.debian.org; 6 May 2005 12:22:10 +0000
>From mh+debian-packages@zugschlus.de Fri May 06 05:22:10 2005
Return-path: <mh+debian-packages@zugschlus.de>
Received: from 5301d.unt0.torres.l21.ma.zugschlus.de (torres.int.l21.ma.zugschlus.de) [] (Debian-exim)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DU1qM-0003FP-00; Fri, 06 May 2005 05:22:10 -0700
Received: from lefler.int.l21.ma.zugschlus.de ([])
	by torres.int.l21.ma.zugschlus.de with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32)
	(Exim 4.50)
	id 1DU1pQ-0002Pk-2p; Fri, 06 May 2005 14:21:12 +0200
Received: from mh by lefler.int.l21.ma.zugschlus.de with local (Exim 4.50)
	id 1DU1pP-0004fU-0I; Fri, 06 May 2005 14:21:11 +0200
Date: Fri, 6 May 2005 14:21:10 +0200
From: Marc Haber <mh+debian-packages@zugschlus.de>
To: 293559-done@bugs.debian.org, 283110-done@bugs.debian.org,
	287535-done@bugs.debian.org, 268841-done@bugs.debian.org,
	268837-done@bugs.debian.org, 286227-done@bugs.debian.org,
	268402-done@bugs.debian.org, 278937-done@bugs.debian.org,
	270266-done@bugs.debian.org, 279659-done@bugs.debian.org,
	273010-done@bugs.debian.org, 271142-done@bugs.debian.org,
	271829-done@bugs.debian.org, 231809-done@bugs.debian.org
Cc: Marc Haber <mh+debian-packages@zugschlus.de>
Subject: Closing bugs
Message-ID: <20050506122110.GA17295@lefler.int.l21.ma.zugschlus.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.9i
Delivered-To: 231809-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 

These bugs have been tagged as fixed-in-experimental, and are now
being closed completely. That should have happened long ago.


Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835