Bug#224301: [Adduser-devel] Bug#224301: Some thoughts about this bug report

[Marc Haber]

On Mon, Oct 24, 2005 at 11:51:56PM +0200, Denis Barbier wrote:
> On Sat, Oct 22, 2005 at 09:02:28PM +0200, Marc Haber wrote:
> > > Of course this comment may be improved ;)
> > > You need to call xgettext with the -c flag so that comments are
> > > inserted
> > > into PO files.
> > 
> > that would be XGETTEXT = xgettext -c in po/Makefile, right? Done.
> 
> Hmmm, I prefer adding -c after $(XGETTEXT).

Changed.

> There is another glitch with po/Makefile:
>  adduser-3.76/po$ touch ../adduser
>  adduser-3.76/po$ make adduser.pot
>  xgettext -c -L Perl -kgtx -o adduser.pot ../adduser
> Strings from deluser are then discarded.  Patch attached.

Applied.

> Yes, but xgettext still displays a warning.
> In AdduserCommon.pm, you can replace
>   sub gtx {
>       return gettext( join "", @_);
>   }
> by
>   sub gtx {
>       return gettext(shift):
>   }
> to remove this warning.  Calling gtx with a list is wrong, because
> only the first string is extracted into the POT file (see the attached
> patch, the 2nd string from deluser is not in adduser.pot).

Applied.

> > > Here is a patch.  I tested it, but of course it may introduce bugs,
> > > please review it carefully ;)
> > 
> > I applied the changes, but left gtx intact. Please reconsider this
> > suggestion.
> 
> Frankly, I see no reason to keep this wrapper.  If you do not want
> localized messages, run your scripts with LC_ALL=C.

It is consistent with the way gettext is used in C programs, and it
allows gettext to be disabled completely, which might be an advantage
on low memory systems.

I have committed your changes and will upload 3.78 later today. Can
you then please take a new look at the package?

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835