[Adduser-devel] tentative patch for multiple bugs about adding new users to extra groups

[Stephen Gran]

This one time, at band camp, Marc Haber said:
> On Sun, Apr 23, 2006 at 02:03:47PM +0100, Stephen Gran wrote:
> > This one time, at band camp, Stephen Gran said:
> > > This is a very tentative patch for adding new user to various groups
> > > by default.  
> > 
> > And it had an obvious bug that I noticed 3 seconds after sending it.
> > Grr.
> > 
> > This one actually test that $config{"extra_groups"} is set before doing
> > anything silly, and also fixes a misplaced ')'.
> 
> I have committed the patch to svn after uploading adduser 3.87. At the
> time of this writing, I intend to put 3.88 into experimental.
> 
> Stephen, can you provide test suite cases for your patch?

OK, let me just throw out ideas for writing the testsuite before doing
so.  My idea is that the test suite should call adduser --add_extra_groups
and check that 
a) all extra groups are added to the user account
b) cleanup is handled correctly
c) invalid groups get handled correctly throughout

Am I missing anything?

Thanks,
-- 
 -----------------------------------------------------------------
|   ,''`.                                            Stephen Gran |
|  : :' :                                        sgran at debian.org |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20060426/39724375/attachment.pgp