[Adduser-devel] Bug#381923: rpcinfo: can't contact portpammer: RPC: Remote system error - Connection refused

[Marc Haber]

On Mon, Aug 07, 2006 at 09:59:41PM +0200, Michael Prokop wrote:
> Would be nice to improve handling of nis "error messages" as people
> seem to interpret the message as a bug.

And here is the attachment.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835
-------------- next part --------------
Index: debian/changelog
===================================================================
--- debian/changelog	(revision 645)
+++ debian/changelog	(working copy)
@@ -1,8 +1,10 @@
 adduser (3.96.0) UNRELEASED; urgency=low
 
   * NOT RELEASED YET
+  * Don't show rpcinfo -p errors to the user.
+    Thanks to Michael Prokop. Closes: #381923
 
- -- Marc Haber <mh+debian-packages at zugschlus.de>  Mon, 31 Jul 2006 07:08:01 +0000
+ -- Marc Haber <mh+debian-packages at zugschlus.de>  Tue,  8 Aug 2006 09:07:58 +0000
 
 adduser (3.96) unstable; urgency=low
 
Index: AdduserCommon.pm
===================================================================
--- AdduserCommon.pm	(revision 645)
+++ AdduserCommon.pm	(working copy)
@@ -20,8 +20,12 @@
     } elsif(-f "/etc/init.d/nis") {
         $nisconfig = "/etc/init.d/nis";
     }
+    # find out whether a local ypserv is running
+    # We can ditch any rpcinfo error since if the portmapper is nonfunctional,
+    # we couldn't connect to ypserv anyway. If this assumption is invalid,
+    # please file a bug and suggest a better way.
     if(defined($nisconfig) && -f "/var/yp/Makefile" &&
-        -x "/usr/bin/rpcinfo" && grep(/ypserv/, qx{/usr/bin/rpcinfo -p})) {
+        -x "/usr/bin/rpcinfo" && grep(/ypserv/, qx{/usr/bin/rpcinfo -p 2>/dev/null})) {
 	open(NISCONFIG, "<$nisconfig");
 	if(grep(/^NISSERVER=master/, <NISCONFIG>)) {
             system("make", "-C", "/var/yp");