[Adduser-devel] Bug#377701: More improvements for the program output

[Joerg Hoh]

Hi

On Mon, Jul 10, 2006 at 09:02:03PM +0200, Tobias Toedter wrote:
> I've also reworded the help texts in version() and usage(), to be more 
> alike.

Looks good.

> All of this is optional, of course, and you may choose freely what to apply.

I think, we should apply these patches (I did some remarks on them, see
below).

Thank you for your help, we really appreciate it.


>  # adduser: a utility to add users to the system
>  # addgroup: a utility to add groups to the system
> -my $version = "VERSION";
> +my $version = "3.92";


>  # deluser -- a utility to remove users from the system
>  # delgroup -- a utilty to remove groups from the system
> -my $version = "VERSION";
> +my $version = "3.92";

Don't hardcode the version information here and keep the VERSION string
here, the build system will replace it.

>  if (($config{remove_home} || $config{remove_all_files} || $config{backup}) && ($install_more_packages)) {
>      die (gtx("In order to use the --remove-home, --remove-all-files, and --backup features,
>  you need to install the `perl-modules' package. To accomplish that, run
> -apt-get install perl-modules\n"));
> +apt-get install perl-modules.\n"));

I think we can ommit the trailing period, because it's a line you can c&p
to the command line.


Jörg

-- 
What did you do to the cat? It looks half-dead. -Schroedinger's wife
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/adduser-devel/attachments/20060710/52a15a67/attachment.pgp