[Adduser-devel] Bug#675804: adduser: some addgroup warnings don't show the process name (please use warnf)

[Vincent Lefevre]

Package: adduser
Version: 3.113+nmu3
Severity: normal

In the adduser/addgroup perl script, some addgroup warnings don't
show the process name, and this makes the message appear to come from
something else in scripts (like when installing gdm3). I suppose that
the warnf subroutine should be used (like some other warnings), with
the additional difference that the warning messages will be sent to
stderr instead of stdout (but I suppose that stderr is better).
Here's the affected code:

if (defined($special_home) && $verbose) {
    printf gtx("Warning: The home dir %s you specified already exists.\n"),$special_home
      if (!defined($no_create_home) && -d $special_home);
    printf gtx("Warning: The home dir %s you specified can't be accessed: %s\n"), $special_home, $!
      if (defined($no_create_home) && ! -d $special_home);
}

Compare to:

          warnf gtx("Warning: The home directory `%s' does not belong to the user you are currently creating.\n"), $home_dir;

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=POSIX, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages adduser depends on:
ii  debconf [debconf-2.0]  1.5.43
ii  passwd                 1:4.1.5.1-1
ii  perl-base              5.14.2-11

adduser recommends no packages.

Versions of packages adduser suggests:
ii  liblocale-gettext-perl  1.05-7+b1
ii  perl-modules            5.14.2-11

-- debconf information:
* adduser/homedir-permission: true
  adduser/title: