[Aptitude-svn-commit] r4008 - in branches/aptitude-0.3/aptitude: . src/generic

Daniel Burrows dburrows at costa.debian.org
Wed Aug 31 06:03:13 UTC 2005


Author: dburrows
Date: Wed Aug 31 06:03:09 2005
New Revision: 4008

Modified:
   branches/aptitude-0.3/aptitude/ChangeLog
   branches/aptitude-0.3/aptitude/src/generic/tags.cc
Log:
Optimize tag::operator++ a bit.

Modified: branches/aptitude-0.3/aptitude/ChangeLog
==============================================================================
--- branches/aptitude-0.3/aptitude/ChangeLog	(original)
+++ branches/aptitude-0.3/aptitude/ChangeLog	Wed Aug 31 06:03:09 2005
@@ -1,5 +1,10 @@
 2005-08-30  Daniel Burrows  <dburrows at debian.org>
 
+	* src/generic/tags.cc:
+
+	  Optimize tag::operator++: testing for whitespace isn't strictly
+	  necessary so don't waste time calling isspace.
+
 	* src/main.cc:
 
 	  Add a "nop" command, which might or might not be useful for

Modified: branches/aptitude-0.3/aptitude/src/generic/tags.cc
==============================================================================
--- branches/aptitude-0.3/aptitude/src/generic/tags.cc	(original)
+++ branches/aptitude-0.3/aptitude/src/generic/tags.cc	Wed Aug 31 06:03:09 2005
@@ -55,7 +55,7 @@
 tag::const_iterator &tag::const_iterator::operator++()
 {
   start = finish;
-  while(start != limit && (isspace(*start) || (*start)==':'))
+  while(start != limit && (*start)==':')
     ++start;
 
   if(start == limit)
@@ -63,7 +63,7 @@
   else
     {
       finish = start+1;
-      while(finish != limit && !(isspace(*finish) || (*finish) == ':'))
+      while(finish != limit && (*finish) != ':')
 	++finish;
     }
 



More information about the Aptitude-svn-commit mailing list