[Aptitude-svn-commit] r3522 - in branches/aptitude-0.3/aptitude: . src/vscreen

[Daniel Burrows]

Author: dburrows
Date: Sat Jul  2 03:56:30 2005
New Revision: 3522

Modified:
   branches/aptitude-0.3/aptitude/ChangeLog
   branches/aptitude-0.3/aptitude/src/vscreen/curses++.cc
   branches/aptitude-0.3/aptitude/src/vscreen/curses++.h
   branches/aptitude-0.3/aptitude/src/vscreen/vscreen_widget.h
Log:
Pass strings by reference, not value.

Modified: branches/aptitude-0.3/aptitude/ChangeLog
==============================================================================
--- branches/aptitude-0.3/aptitude/ChangeLog	(original)
+++ branches/aptitude-0.3/aptitude/ChangeLog	Sat Jul  2 03:56:30 2005
@@ -2,6 +2,10 @@
 
 	* src/vscreen/curses++.cc, src/vscreen/curses++.h, src/vscreen/vscreen_widget.h:
 
+	  While I'm at it...pass strings by reference, not value.
+
+	* src/vscreen/curses++.cc, src/vscreen/curses++.h, src/vscreen/vscreen_widget.h:
+
 	  Update show_string_as_progbar for wide characters.
 
 	* src/download_bar.cc, src/download_bar.h:

Modified: branches/aptitude-0.3/aptitude/src/vscreen/curses++.cc
==============================================================================
--- branches/aptitude-0.3/aptitude/src/vscreen/curses++.cc	(original)
+++ branches/aptitude-0.3/aptitude/src/vscreen/curses++.cc	Sat Jul  2 03:56:30 2005
@@ -268,7 +268,7 @@
   return amt;
 }
 
-void cwindow::show_string_as_progbar(int x, int y, wstring s,
+void cwindow::show_string_as_progbar(int x, int y, const wstring &s,
 				     int attr1, int attr2, int size1,
 				     int totalsize)
 {

Modified: branches/aptitude-0.3/aptitude/src/vscreen/curses++.h
==============================================================================
--- branches/aptitude-0.3/aptitude/src/vscreen/curses++.h	(original)
+++ branches/aptitude-0.3/aptitude/src/vscreen/curses++.h	Sat Jul  2 03:56:30 2005
@@ -544,7 +544,7 @@
   int getmaxy() {return _getmaxy(win);}
   int getmaxx() {return _getmaxx(win);}
 
-  void show_string_as_progbar(int x, int y, std::wstring s,
+  void show_string_as_progbar(int x, int y, const std::wstring &s,
 			      int attr1, int attr2, int size1,
 			      int totalsize);
   // Glitz bit :) Displays the given string with a progress bar behind it.

Modified: branches/aptitude-0.3/aptitude/src/vscreen/vscreen_widget.h
==============================================================================
--- branches/aptitude-0.3/aptitude/src/vscreen/vscreen_widget.h	(original)
+++ branches/aptitude-0.3/aptitude/src/vscreen/vscreen_widget.h	Sat Jul  2 03:56:30 2005
@@ -343,7 +343,7 @@
   int getmaxy() {return win?win.getmaxy():0;}
   int getmaxx() {return win?win.getmaxx():0;}
 
-  void show_string_as_progbar(int x, int y, std::wstring s,
+  void show_string_as_progbar(int x, int y, const std::wstring &s,
 			      const style &st1, const style &st2,
 			      int size1, int totalsize)
   {