[Aptitude-svn-commit] r4285 - in branches/aptitude-0.3/aptitude: . src

[Daniel Burrows]

Author: dburrows
Date: Mon Sep 26 07:04:19 2005
New Revision: 4285

Modified:
   branches/aptitude-0.3/aptitude/ChangeLog
   branches/aptitude-0.3/aptitude/src/pkg_item.cc
Log:
Hang onto the package cache lock while reporting a bug, as the
previous behavior was extremely surprising.

Modified: branches/aptitude-0.3/aptitude/ChangeLog
==============================================================================
--- branches/aptitude-0.3/aptitude/ChangeLog	(original)
+++ branches/aptitude-0.3/aptitude/ChangeLog	Mon Sep 26 07:04:19 2005
@@ -1,3 +1,12 @@
+2005-09-26  Daniel Burrows  <dburrows at debian.org>
+
+	* src/pkg_item.cc:
+
+	  Hang onto the lock while running reportbug.  This obviates the
+	  need to reload the package cache, and in particular it means
+	  that aptitude no longer discards information about package
+	  states after reporting a bug; hence (Closes: #304748).
+
 2005-09-25  Daniel Burrows  <dburrows at debian.org>
 
 	* src/ui.cc:

Modified: branches/aptitude-0.3/aptitude/src/pkg_item.cc
==============================================================================
--- branches/aptitude-0.3/aptitude/src/pkg_item.cc	(original)
+++ branches/aptitude-0.3/aptitude/src/pkg_item.cc	Mon Sep 26 07:04:19 2005
@@ -394,17 +394,11 @@
 
       vscreen_suspend();
 
-      apt_cache_file->ReleaseLock();
-
       printf(_("Reporting a bug in %s:\n"), package.Name());
 
       system(cmd.c_str());
 
       vscreen_resume();
-
-      vs_progress_ref p = gen_progress_bar();
-      apt_reload_cache(p.unsafe_get_ref(), true);
-      p->destroy();
     }
   else if(bindings->key_matches(k, "DpkgReconfigure"))
     // Don't bother with my internal su-to-root stuff here, since I don't