[Aptitude-svn-commit] r4353 - in branches/aptitude-0.3/aptitude: . src/cmdline

[Daniel Burrows]

Author: dburrows
Date: Fri Sep 30 01:25:21 2005
New Revision: 4353

Modified:
   branches/aptitude-0.3/aptitude/ChangeLog
   branches/aptitude-0.3/aptitude/src/cmdline/cmdline_do_action.cc
Log:
Fix cmdline_do_action so that it doesn't always act like download_only is true.

Modified: branches/aptitude-0.3/aptitude/ChangeLog
==============================================================================
--- branches/aptitude-0.3/aptitude/ChangeLog	(original)
+++ branches/aptitude-0.3/aptitude/ChangeLog	Fri Sep 30 01:25:21 2005
@@ -1,5 +1,13 @@
 2005-09-29  Daniel Burrows  <dburrows at debian.org>
 
+	* src/cmdline/cmdline_do_action.cc:
+
+	  Fix a nasty bug: when constructing the download manager in
+	  do_action, I was actually (and accidentally) constructing a
+	  manager on the heap, implicitly casting it to bool (hence always
+	  getting 'true') and then passing that as download_only to the
+	  true manager.  Obviously this is not quite what was desired.
+
 	* src/ui.cc, src/ui_download_manager.cc, src/ui_download_manager.h, src/view_changelog.cc:
 
 	  Require code that creates a ui_download_manager to set all the

Modified: branches/aptitude-0.3/aptitude/src/cmdline/cmdline_do_action.cc
==============================================================================
--- branches/aptitude-0.3/aptitude/src/cmdline/cmdline_do_action.cc	(original)
+++ branches/aptitude-0.3/aptitude/src/cmdline/cmdline_do_action.cc	Fri Sep 30 01:25:21 2005
@@ -234,8 +234,7 @@
 	  return 0;
 	}
 
-      download_install_manager m =
-	new download_install_manager(download_only);
+      download_install_manager m(download_only);
 
       int rval =
 	(cmdline_do_download(&m) == download_manager::success ? 0 : -1);