Bug#803176: autodep8: please fix the way nodejs/generate gets upstream_name

[Jérémy Lal]

2015-10-27 22:09 GMT+01:00 Antonio Terceiro <terceiro at debian.org>:

> On Tue, Oct 27, 2015 at 06:09:00PM +0100, Jérémy Lal wrote:
> > Package: autodep8
> > Version: 0.2
> > Severity: normal
> >
> > Dear Maintainer,
> >
> > Please use this one-liner instead
> >
> > upstream_name=$(python -c "import json;
> print(json.load(open('package.json'))['name'])")
>
> this broke on the very first NodeJS package I went to try it (requirejs):
>
> $ pwd
> /tmp/requirejs-2.1.20
> $ python -c "import json; print(json.load(open('package.json'))['name'])"
> Traceback (most recent call last):
>   File "<string>", line 1, in <module>
>   KeyError: 'name'
>
> We probably want to fallback to looking at the source package name?


This is the first time i see this.
Yes, keeping existing code as fallback seems to be safer.

Note that there is something odd with that module...

https://github.com/jrburke/r.js
https://github.com/jrburke/r.js/commit/40fa066e

https://github.com/jrburke/requirejs
https://github.com/jrburke/requirejs/commit/a2029ccd

So the correct upstream source seems to be requirejs, not r.js.
In any case upstream is using a meta-packager (volo) so in this case
package.json cannot be trusted (the fact it is available in the git
repository is misleading - it shouldn't even be there).

Jérémy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/autopkgtest-devel/attachments/20151027/d602a132/attachment.html>