RFC (v2): adding --add-apt-source and --pin-packages to autopkgtest

[Antonio Terceiro]

Hi,

On Sun, Oct 29, 2017 at 06:48:04PM -0200, Antonio Terceiro wrote:
> Hi,
> 
> I received feedback from Paul yesterday about my last commit in the
> original pull request, and revisited it. Instead of automatically adding
> APT sources entries when --pin-packages is used, I split that into a
> separate option. This makes the system more flexible for other use
> cases.
> 
> This v2 is exacly the same as before except for the last commit.
> 
> ------------------------------------------------------------------------
> 
> We need a few new features in autopkgtest in order to have ci.debian.net
> gating updates to Debian testing. This could be done with setup-command
> hacks on debci, but autopkgtest is the right place for the
> functionality.
> 
> This work was started by Paul Gevers. I recently joined the efforts
> since I needed to understand the autopkgtest side to properly implement
> debci side, and I added a few improvements that will make my work on
> debci easier.
> 
> --add-apt-sources can be used to add extra APT sources. This is probably
> very useful to test packages from overlay repositories against a "clean"
> originail testbed. It is not strictly needed for our CI work, but
> --pin-packages shares some of the implementation, so we might as well
> also have it.
> 
> --pin-packages is a generalization of --apt-pocket that works for the
> Debian case. In fact, some refactoring was done so that a good part of
> the implementation of both options is now shared. Different from
> --apt-pocket, --pin-packages won't automatically add APT entries. For
> doing that, there is a now an --add-apt-release option, which is a
> shortcut for adding new APT source entries to the testbed.
> 
> I intend to merge this and make a 5.1 release, but it would be nice to
> have some code review.
> 
> All previously existing automated tests still pass, and based on my
> local tests I would say that we are good.  Below is the summary of the
> changes produced with `git request-pull`.
> 
> ------------------------------------------------------------------------
> 
> The following changes since commit 433f1b007f3c84a8f552122a670a40a1efde3f4a:
> 
>   debian/rules: reuse /usr/share/dpkg/pkg-info.mk (2017-10-25 22:47:36 -0200)
> 
> are available in the Git repository at:
> 
>   https://anonscm.debian.org/git/users/terceiro/autopkgtest.git pin-v2
> 
> for you to fetch changes up to e5a6c6ba5c2fa71829930bf46dd98363a656f420:
> 
>   Add --add-apt-release option (2017-10-29 12:36:18 -0200)
> 
> ----------------------------------------------------------------
> Antonio Terceiro (5):
>       Merge remote-tracking branch 'paulgevers/gating-via-sources-rebased' into pin
>       Fix description of --pin-packages in manpage
>       Simplify check for need to run setup commands
>       Extract "add APT source" into its own method
>       Add --add-apt-release option
> 
> Paul Gevers (6):
>       Error out when apt-get update fails for three times in a row
>       Add release- to help text of apt-pocket
>       Apply patch by Simon McVittie from bug #851568
>       Improve man page for --setup-commands, as both examples are now supported natively
>       Use APT:Default-Release i.s.o. most pinning and add option --apt-default-release
>       Add --pin-packages option to enable Debian to run in testing with packages from sid
> 
>  lib/adt_testbed.py      | 145 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------
>  lib/autopkgtest_args.py |  29 +++++++++++++++++++++++++++--
>  runner/autopkgtest      |   6 +++++-
>  runner/autopkgtest.1    |  49 +++++++++++++++++++++++++++++++++++++++++++-----
>  tests/autopkgtest       | 116 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------
>  5 files changed, 306 insertions(+), 39 deletions(-)

I have just uploaded autopkgtest 5.1, including the above changes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/autopkgtest-devel/attachments/20171122/ef921967/attachment.sig>