I proudly present: first version of apt-release

Martin Pitt mpitt at debian.org
Sun Sep 17 19:37:53 UTC 2017


Hello Paul,

Paul Gevers [2017-08-08 21:17 -0400]:
> >> FYI, Simon propopsed a more generic way to add an entire apt line in #851568,
> >> which then would resolve any ambiguity like the ones above. The charm of
> >> --apt-pocket is that it can stay a hardcoded value in a CI system, but the same
> >> won't really extend for full series names. So maybe for this having an
> >> --apt-source which gets the full line (maybe with some magic <mirror>
> >> replacement from the existing apt sources) might be both more flexible and less
> >> confusing?
> > 
> > I'll let that idea sink in. I think that would mean that we would treat
> > --apt-pocket and --apt-source quite different again, but maybe that
> > isn't too bad.
> 
> I decided to build my implementation on this idea. For that to work I
> needed to do some things slightly different for -pockets as well, but I
> believe in a better way. Could you please comment on my work and see how
> you like it now?
> 
> Paul
> 
> ¹ https://github.com/paulgevers/autopkgtest/tree/gating-via-sources

I think the general direction of that is fine. I commented on the github
commits, as that's a rather convenient place. However, that wasn't ideal either
as a lot of the commits belong together or change previous commits; OTOH,
diffing your branch against master (to get the complete picture) is also a bit
difficult as they diverted a bit. Can you please rebase your branch against
master and squash related commits together? (Like defining an option,
implementing it, and the corresponding test case).

Indeed --apt-pocket and --apt-source are now quite different, I don't see how
to efficiently merge them or reimplement --apt-pocket "on top of"
--apt-source. But I think that's ok, as long as both have proper tests.

Thanks!

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/autopkgtest-devel/attachments/20170917/0afa1446/attachment.sig>


More information about the autopkgtest-devel mailing list