[Bash-completion-devel] [PATCHES] review some patches from Mandriva

[Ville Skyttä]

Hi Guillaume, others,

First a general question about the patches: are all of them written by you or 
contributed by other people?  I'd like to be sure credit for them goes to the 
correct folks.

Then, some comments about some of the patches, will try to take a look at the 
rest soon unless someone beats me to it:

On Tuesday 13 January 2009, Santiago M. Mola wrote:
> El lun, 12-01-2009 a las 23:55 +0100, Guillaume Rousse escribió:
>
> > Thoses patches correct some details in rpm completion:
> > bash-completion-20060301-fix-old-rpmfiles-pattern.patch
>
> Looks good.

Already taken care of in bzr as part of 
http://bzr.debian.org/loggerhead/bash-completion/current/revision/1232?

> > bash-completion-20060301-rpm-macros.patch
>
> Is /etc/rpm/macros.d present on all rpm-based systems? If not, you may
> want to check for its existence.

Current bzr has an improved way of grabbing the list of available rpm macros 
that doesn't depend on any particular files (file based approaches to this 
tend to be incomplete and fragile (the bzr version isn't that pretty either 
but I think it's clearly an improvement)): 
http://bzr.debian.org/loggerhead/bash-completion/current/revision/1229?

> > bash-completion-20090108-lzma-completion.patch

Partially already applied/superseded in bzr, I intend to apply the rest 
tonight (I've had the patch around in Fedora packages for some time and it 
has worked fine).  Will most likely commit the actual lzma completion as a 
separate file in contrib/ though.

> > bash-completion-20060301-getent-completion.patch
>
> Looks good.

Superseded in bzr: 
http://bzr.debian.org/loggerhead/bash-completion/current/revision/1240?


As a general remark, I suggest taking a look at current bzr head and recent 
changes; I've committed quite a few things lately and there's still a few 
patches forthcoming.