[Bash-completion-devel] [PATCHES] review some patches from Mandriva

[Guillaume Rousse]

Santiago M. Mola a écrit :
> Hi,
> 
> Let's review some patches.
> 
> El lun, 12-01-2009 a las 23:55 +0100, Guillaume Rousse escribió: 
>> Second, I'd prefer all potentially slow completion (rpm database
>> querying, scp remote completion) to be easily desactivable. For those
>> reason, we patch openssh and rpm completion to add COMP_RPM_DATABASE and
>> COMP_SCP_REMOTE variables. See 
>> bash-completion-20090108-rpm-database.patch and 
>> bash-completion-20090108-scp-remote.patch in our bash-completion package
>> sources:
>> http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/bash-completion/current/SOURCES
>>
> 
> I think this needs a more general solution. See the thread "New
> directory layout" for a start. If that doesn't provide enough
> granularity, maybe there could be a variable
> BASH_COMPLETION_DISABLE_COMMANDS or similar with a list of disabled
> commands.
This is misunderstanding. Sometimes you want to disable only the slow 
part of a completion for a given command, not the whole completion 
itself. For instance, rpm completion on installed packages is fast, as 
long as it can uses its cache, that's only querying the database 
directly that is slow. The same is true for scp completion on the remote 
host, which may be slow, while local completion doesn't have any trouble.

-- 
Guillaume Rousse