[Bash-completion-devel] [bash-completion-Bugs][311386] DBTS 503317: function _dpkg_source contains a inappropriate exit statement

[bash-completion-bugs at alioth.debian.org]

Bugs item #311386, was opened at 30/01/2009 09:37
>Status: Closed
Priority: 3
Submitted By: David Paleino (hanska-guest)
>Assigned to: David Paleino (hanska-guest)
Summary: DBTS 503317: function _dpkg_source contains a inappropriate exit  statement  
Distribution: Debian
Originally reported in: Debian BTS
Original bug number: 503317


Initial Comment:
_dpkg_source contains a inappropriate exit statement, which forces
the shell to exit. I suppose this should be 'return' instead.

Reproduce: Open a bash-shell , type '_dpkg_source<RET>'.

Patch follows:

diff -c -L /su:root at localhost:/etc/bash_completion -L /tmp/buffer-content-2677a0z /tmp/tramp.2677M-C /tmp/buffer-content-2677a0z
*** /su:root at localhost:/etc/bash_completion
--- /tmp/buffer-content-2677a0z
***************
*** 4457,4463 ****
  
  	COMPREPLY=()
  	if [ "$1" != "dpkg-source" ]; then
! 		exit 1
  	fi
  	cur=`_get_cword`
  	prev=${COMP_WORDS[COMP_CWORD-1]}
--- 4457,4463 ----
  
  	COMPREPLY=()
  	if [ "$1" != "dpkg-source" ]; then
! 		return 1
  	fi
  	cur=`_get_cword`
  	prev=${COMP_WORDS[COMP_CWORD-1]}


----------------------------------------------------------------------

>Comment By: David Paleino (hanska-guest)
Date: 30/01/2009 09:37

Message:
Fixed in r1195.

----------------------------------------------------------------------

You can respond by visiting: 
http://alioth.debian.org/tracker/?func=detail&atid=413095&aid=311386&group_id=100114