[Bash-completion-devel] Layout change

[Ville Skyttä]

On 05/02/2011 07:34 PM, David Paleino wrote:
> On Mon, 02 May 2011 19:18:03 +0300, Ville Skyttä wrote:
> 
>> On 05/02/2011 06:07 PM, David Paleino wrote:
>>
>>> $ tree -L 1 /usr/share/bash-completion/
>>> /usr/share/bash-completion/
>>> |-- bash_completion
>>> |-- completions
>>> `-- helpers
>>
>> That looks fine to me, but I'd like to get rid of the
>> BASH_COMPLETION_DIR and BASH_COMPLETION_HELPERS_DIR variables
>> altogether.  I don't see why they would be required, couldn't we just
>> resolve them based on bash_completion's location (i.e. assume that the
>> completions and helpers dirs are in the same dir)?
> 
> What if downstream packagers/final users move things around? Will we let them
> shoot their feet? :)

I don't think there's much we can do to prevent that from happening
anyway ;)  But seriously, the question is why would they want to do it,
can you think of a setup for which the above wouldn't work?
(Remembering that the /usr/share part would remain configurable at build
time.)

> ...if we get rid of BASH_COMPLETION, then we'd need to use BASH_SOURCE somehow?

Yes.

> I'll start with little steps -- first, I'll make everything depend on
> BASH_COMPLETION. After that, I'll RTFM and see how to get rid of it too.

Sounds good to me.

>> Once these things settle down, I intend to add a pkgconfig file that
>> people can use for locating the dirs where they can drop additional
>> completion files.
> 
> Nice :)
> I can do that as well, we just need to settle on some variable names to use
> inside the .pc :)

I think in addition to the usual pkgconfig things completionsdir and
helpersdir would pretty much be it.