[Bash-completion-devel] Bug#648319: bash-completion: /etc/bash_completion script doesn't do the job

[David Paleino]

On Wed, 11 Jan 2012 02:39:43 -0600, Jonathan Nieder wrote:

> rush wrote:
> > 2012/1/11, Jonathan Nieder <jrnieder at gmail.com>:
> 
> >> I don't follow.  Isn't COMPAT_DIR _supposed_ to point to
> >> /etc/bash_completion.d?  Which completion is not working?
> >
> > If I specify /etc/bash_completion.d in this variable noone from
> > /usr/share/bash-completion/completions/ will work. I tested on ssh,
> > ip, apt-get, aptitude and others (nothing happens on TAB [[only dirs
> > suggested for completion]]).
> 
> Ah, I see.  Good catch --- it's due to this line:
> 
>     [[ $BASH_SOURCE == */* ]] && compdir="${BASH_SOURCE%/*}/completions"
> 
> Probably something like
> 
>     local compscript=$(readlink -f "$BASH_SOURCE")
>     [[ $compscript == */* ]] && compdir="${compscript%/*}/completions"
> 
> in its place would do the trick.

Oh, thanks for the quick fix, and thanks for finding the bug :)

The proposed patch makes perfectly sense, thanks Jonathan! I committed it
upstream, and I just uploaded 1.99-3 to the repositories.

Enjoy,
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/bash-completion-devel/attachments/20120111/834c7779/attachment.pgp>