[Bash-completion-devel] [bash-completion-Bugs][313498] [lp:776561] modinfo failing when -k {version} {modname}[tab]

[bash-completion-bugs at alioth.debian.org]

Bugs item #313498, was changed at 2012-01-09 06:38 by Igor Murzov
You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=413095&aid=313498&group_id=100114

>Status: Closed
Priority: 3
Submitted By: Daniel Black (grooverdan-guest)
Assigned to: Igor Murzov (garik-guest)
Summary: [lp:776561] modinfo failing when -k {version} {modname}[tab] 
Distribution: Ubuntu
Originally reported in: Ubuntu Launchpad
Milestone: None
Status: Fix Committed
Original bug number: 776561


Initial Comment:
from:https://bugs.launchpad.net/ubuntu/+source/bash-completion/+bug/776561

insmod, modprobe and modinfo are handled by one function: _insmod. There is a problem with this approach: the programs are completely different.

insmod does not accept options like -x and --xxx, only modules or paths to modules.

modprobe accepts several -x and --xxx options, these can not always be combined.

modinfo acepts paths to modules or module names, the kernel version can be specified

The following cases generate errors / unexpected behavior:
$ insmod x x<tab>
ERROR: modinfo: could not find module x
$ modinfo x x<tab>
ERROR: modinfo: could not find module x
$ modprobe x x<tab>
ERROR: modinfo: could not find module x
$ modinfo -k 2.6.35-28-generic x<tab>
/sbin/modinfo: option requires an argument -- 'k'
Usage: /sbin/modinfo [-0][-F field][-k kernelversion][-b basedir] module...
 Prints out the information about one or more module(s).
 If a fieldname is given, just print out that field (or nothing if not found).
 Otherwise, print all information out in a readable form
 If -0 is given, separate with nul, not newline.
 If -b is given, use an image of the module tree.

The proposed patch fixes these issues (partially):
- insmod: completely fixed
- modprobe: arguments are incomplete (todo)
- modinfo: completely fixed

The patch can be added to the debian/patches/ directory directly after a review.

----
patch from DBTS
https://launchpadlibrarian.net/71011240/module-init-tools.patch

---

also failing against 1.90

----------------------------------------------------------------------

>Comment By: Igor Murzov (garik-guest)
Date: 2012-01-13 06:11

Message:
Ok, closed then.

----------------------------------------------------------------------

Comment By: Daniel Black (grooverdan-guest)
Date: 2012-01-13 04:13

Message:
works for me.

----------------------------------------------------------------------

Comment By: Igor Murzov (garik-guest)
Date: 2012-01-13 00:57

Message:
Should be fixed in commit: http://anonscm.debian.org/gitweb/?p=bash-completion/bash-completion.git;a=commit;h=f67818e023f9afbeef8698fdd3c08eb0f90ad468

Please review and test!

----------------------------------------------------------------------

You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=413095&aid=313498&group_id=100114