[Bash-completion-devel] [bash-completion-Bugs][313892] Fix race condition for symlinks

[bash-completion-bugs at alioth.debian.org]

bash-completion-Bugs item #313892, was changed at 2012-11-06 21:06 by Ville Skyttä
You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=413095&aid=313892&group_id=100114

>Status: Open
Priority: 3
Submitted By: Nobody (None)
Assigned to: Nobody (None)
Summary: Fix race condition for symlinks 
Distribution: None
Originally reported in: None
Milestone: None
Status: Fix Committed
Original bug number: 


Initial Comment:
with

make -j 16 DESTDIR=/home/andreas/tmp/oe-core-eglibc/work/all-angstrom-linux/bash-completion-2.0-r0/image install

I sometimes get something like:

| ln: failed to create symbolic link `/home/andreas/tmp/oe-core-eglibc/work/all-angstrom-linux/bash-completion-2.0-r0/image/usr/share/bash-completion/completions/aclocal-1.11': No such file or directory
| make[2]: *** [symlinks] Error 1
| make[2]: *** Waiting for unfinished jobs....

Attached is a patch that fixes the problem.

Andreas Mueller

----------------------------------------------------------------------

>Comment By: Ville Skyttä  (scop-guest)
Date: 2012-11-06 21:06

Message:
I feel somewhat uncomfortable with this patch because $(DATA) is something out of our control I believe, dunno if it's even a documented feature of autotools. Shouldn't we be using $(bashcomp_DATA) instead?

And further, I don't quite grok why either $(DATA) or $(bashcomp_DATA) would fix this if the error is because the "completions" dir hasn't been created yet...

----------------------------------------------------------------------

Comment By: Igor Murzov (garik-guest)
Date: 2012-11-06 17:09

Message:
The patch has been applied:
http://anonscm.debian.org/gitweb/?p=bash-completion/bash-completion.git;a=commit;h=370b7a0d2fdf7f322b59f3c35c1cea19901ef2f2

Thank you for the patch.

----------------------------------------------------------------------

You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=413095&aid=313892&group_id=100114