[Bash-completion-devel] Improve make target completion

[Igor Murzov]

Patch has been applied with minor corrections. Thanks.
http://anonscm.debian.org/gitweb/?p=bash-completion/bash-completion.git;a=commit;h=39f00f92e52b783e7e9e43aac4b4274cc9dee152

I had to make some small fixes -- eliminate tabs, line
wrapping. Also variable names in upper case are probably
bad, but i didn't touch it.


-- Igor


On Tue, 11 Sep 2012 23:37:37 +0100
Tristan Wibberley <tristan.wibberley at gmail.com> wrote:

> Igor,
> 
> I've attached a new version of incremental completion that is roughly
> as fast as the previous non-incremental version and is also a bit
> clearer than any incremental completion patch I've sent so far.
> 
> Also answers to your questions below:
> 
> 
> On 11 September 2012 21:21, Igor Murzov <e-mail at date.by> wrote:
> >
> > Looks like this one works much slower than the previous.
> 
> Fixed by reverting key elements to be as in the previous incremental
> completion change, but changed the way "mode" modifies the output to
> be a bit clearer.
> 
> 
> >  * if you want to use _make_sed_escape() only once, then
> >    why you need it at all?
> 
> That was just for clarity. The attached patch reverts to not bothering
> - but it does add escaping for comma because the clever expression to
> output only part of the name can use less escaping inline by following
> the form s,lexpr,rexpr, instead of s/lexpr/rexpr/
> 
> Regards
> Tristan