[Bash-completion-devel] [bash-completion-Bugs][314716] LVM completion fixes and enhancements (failglob, sizes...)

[bash-completion-bugs at alioth.debian.org]

bash-completion-Bugs item #314716 was changed at 2014-06-07 12:35 by Ville Skyttä
You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=413095&aid=314716&group_id=100114

Status: Open
Priority: 3
Submitted By: Dams Nadé (anvil-guest)
Assigned to: Nobody (None)
Summary: LVM completion fixes and enhancements (failglob, sizes...) 
Distribution: None
Originally reported in: None
Milestone: None
Status: None
Original bug number: 


Initial Comment:
Please find attached 3 patches for LVM :


* 0001-lvm-_lvm_count_args-parameter-must-be-quoted-in-orde.patch :
In completions/lvm, the _lvm_count_args functions takes a pattern as parameter. In the rest of the file, the given parameter is not correctly quoted.

* 0002-lvm-_lvm-using-a-single-pattern-case-and-invoking-fu.patch
A purely esthetic change, which shortens the 'case' statement in _lvm.

* 0003-lvm-_lvm_sizes-new-implementation-able-to-handle-rel.patch
A new implementation for _lvm_sizes. This should fix the relative-size completion issue described in [#311391].

----------------------------------------------------------------------

>Comment By: Ville Skyttä  (scop-guest)
Date: 2014-06-07 12:35

Message:
0001 and 0002 (with slight modifications) applied, hopefully someone who actually uses lvm will take a look at the rest.

----------------------------------------------------------------------

Comment By: Dams Nadé (anvil-guest)
Date: 2014-06-07 01:41

Message:
0005-lvm-dynamically-compute-the-available-field-names-fo.patch :
The currently provided list of field names for pvs/lvs/vgs is incomplete. I suggest parsing these commands stderr to compute the full list of available fields, thus enhancing the completion.

----------------------------------------------------------------------

Comment By: Dams Nadé (anvil-guest)
Date: 2014-06-07 00:49

Message:
* 0004-lvm-using-vgs-pvs-lvs-in-_lvm_volumegroups-_lvm_phys.patch
We can remove the use of sed in the functions providing pv/vg/lv names by using pvs/vgs/lvs instead of pvscan/vgscan/lvscan.

----------------------------------------------------------------------

You can respond by visiting: 
https://alioth.debian.org/tracker/?func=detail&atid=413095&aid=314716&group_id=100114