[Bash-completion-devel] [PATCH] check if ruptime is installed

Ville Skyttä ville.skytta at iki.fi
Fri Jun 12 11:11:28 UTC 2015


On Fri, Jun 12, 2015 at 1:16 PM, isabella parakiss <izaberina at gmail.com> wrote:
>
> Sorry what?  Ten lines above you check if avahi-browse is installed

Yes, there are some cases where we do that, but it doesn't invalidate
what I said.

> I don't think it's my code that needs to be fixed, and several distros use
> command_not_found_handle to tell the user to install a certain package.
> Are you going to ask them all to check if $COMP_LINE is empty?

I'm going to see if the approach I proposed works sometime, when I
find time and interest, and helping with testing would quite likely
make that happen sooner. Then, if it does work, I'll probably spend
time documenting it in bash-completion's README as well as submit a
related fix to the Fedora PackageKit-command-not-found package. I
suppose that's about as far as I'm prepared to go. I suggest other
distro users and maintainers to do the same thing for the environments
they know and can control.

> There's no reason why they should be forced to change just to allow your
> sloppy code practices.

You are entitled to your opinion wrt what's sloppy etc, but that tone
won't help with getting me to spend my personal time fixing something
I don't consider necessarily broken, doesn't affect me, and is
hard/messy/semi-unmaintainable to fix everywhere in bash-completion
code whereas it could be trivial to fix/workaround in command not
found handlers. And taking care of it there would do it also for other
things besides bash-completion.

> Am I the first one reporting this problem?  I can't believe it.

I'm aware of https://bugzilla.redhat.com/1164410



More information about the Bash-completion-devel mailing list