[Bash-completion-devel] Bug#785271: dh_bash-completion script/file list autodetection fails hiding bugs which can become RC

[Lisandro Damián Nicanor Pérez Meyer]

Package: bash-completion
Version: 1:2.1-4.1
Severity: serious
Justification: hides bugs which can become RC

dh_bash-completion's heuristics for detecting wheter a
debian/package.bash-completion file is a script or a list of files it's not
safe enough, hiding possible bugs which can create RC bugs like #785267.

In this case the problem was that the paths listed contained ther version
of cmake in it. The version changed and dh_bash-completion detected the file
as a script causing #785267, instead of failing and telling the maintainer
that there was a problem.

I think the best thing to do here is simply list files and not expect scripts,
they can easily be added there.

Another way to solve this could be changing the file suffix to something like
bash-completion-script and/or bash-completion-install.

For now the easy way around is using * in the paths, but that's just a
workaround.

Kinds regards, Lisandro.

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)

Versions of packages bash-completion depends on:
ii  bash  4.3-12
ii  dpkg  1.17.25

bash-completion recommends no packages.

bash-completion suggests no packages.

-- no debconf information