Testing/fixing savane/savannah support - Was: Re: Processed: [bts-link] source package phpgroupware

[Pierre Habouzit]

On Mon, Nov 03, 2008 at 10:38:39AM +0000, Olivier Berger wrote:
> Le lundi 03 novembre 2008 à 10:29 +0100, Olivier Berger a écrit :
> 
> > As you can see, I've tested locally and think I have identified a
> > problem with the savane URIs... seems to me that savane support was
> > probably broken.
> > 
> > Any hint ?
> > 
> > I'll try and publish my git repo so that I can provide an idea of the
> > proposed changes.
> > 
> > Regards,
> 
> More specifically, here's the proposed change :
> 
> --------------------------------- btslink.cfg ---------------------------------
> index f1c45b0..4b1c613 100644
> @@ -338,7 +338,8 @@ uri-re   = https?://gna.org/bugs/(?:index.php|)\?(?:.*&)*item_id=([0-9]+)
>  [savannah-gnu]
>  type     = savane
>  uri      = http://savannah.gnu.org/bugs/
> -uri-re   = https?://savannah.gnu.org/bugs/(?:index.php|)\?(?:.*&)*item_id=([0-9]+)
> +uri-re   = https?://savannah.gnu.org/bugs/(?:index.php|)\?([0-9]+)
> +;uri-re   = https?://savannah.gnu.org/bugs/(?:index.php|)\?(?:.*&)*item_id=([0-9]+)
>  
>  [savannah-nongnu]
>  type     = savane
> 
> This is commit f498630a6eaca4691ba0700b49ba2f6d7bb2fa41 in my git repo I've just published at http://www-public.it-sudparis.eu/~berger_o/git/bts-link.git/ 
> 
> I noticed URLs of tickets in savannah are now natively displayed like https://savannah.gnu.org/bugs/?24725 instead of https://savannah.gnu.org/bugs/?func=detailitem&item_id=24725 ...
> 
> Any comments ?

We should still support the old kind of urls. So I guess the regexp is a
tad more complex than that.

Something along the lines of:

uri-re = https?://savannah.gnu.org/bugs/(?:index.php|)\?(?:(?:.*&)*item_id)=([0-9]+)

-- 
·O·  Pierre Habouzit
··O                                                madcoder at debian.org
OOO                                                http://www.madism.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/bts-link-devel/attachments/20081103/156f03f2/attachment.pgp