Bug#205361: [Fwd: [Build-common-hackers] Bug#205361: cdbs: perl modules should install into DEB_DESTDIR]

Thu, 14 Aug 2003 23:20:44 -0400

--=-ZFymPGmYv81qFdIiRBER
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Jonas, did you see this bug report?


--=-ZFymPGmYv81qFdIiRBER
Content-Disposition: inline
Content-Description: Forwarded message - [Build-common-hackers] Bug#205361:
	cdbs: perl modules should install into DEB_DESTDIR
Content-Type: message/rfc822

Return-Path: <build-common-hackers-admin@lists.alioth.debian.org>
X-Original-To: walters@columbia.verbum.private
Delivered-To: walters@columbia.verbum.private
Received: from localhost (columbia [127.0.0.1]) by columbia (Postfix) with
	ESMTP id 54F7C26F5AD for <walters@columbia.verbum.private>; Thu, 14 Aug
	2003 04:41:08 -0400 (EDT)
Delivered-To: walters@verbum.org
Received: from monk.debian.net [216.226.142.128] by localhost with IMAP
	(fetchmail-6.2.3) for walters@columbia.verbum.private (single-drop); Thu,
	14 Aug 2003 04:41:08 -0400 (EDT)
Received: from master.debian.org (master.debian.org [146.82.138.7]) by
	monk.verbum.org (Postfix (Debian/GNU)) with ESMTP id 24BB632A6BB for
	<walters@verbum.org>; Thu, 14 Aug 2003 04:36:11 -0400 (EDT)
Received: from quantz.debian.org [192.87.30.200]  by master.debian.org with
	esmtp (Exim 3.35 1 (Debian)) id 19nDZX-0002oC-00; Thu, 14 Aug 2003 03:35:03
	-0500
Received: from localhost ([127.0.0.1] helo=quantz.debian.org ident=list) by
	quantz.debian.org with esmtp (Exim 3.35 #1 (Debian)) id 19nDZW-0005Rj-00;
	Thu, 14 Aug 2003 10:35:02 +0200
Received: from master.debian.org ([146.82.138.7]) by quantz.debian.org with
	esmtp (Exim 3.35 #1 (Debian)) id 19nDYb-0005RO-00 for
	<build-common-hackers@lists.alioth.debian.org>; Thu, 14 Aug 2003 10:34:05
	+0200
Received: from debbugs by master.debian.org with local (Exim 3.35 1
	(Debian)) id 19nDXb-0002fW-00; Thu, 14 Aug 2003 03:33:03 -0500
X-Loop: owner@bugs.debian.org
Reply-To: Dagfinn Ilmari Mannsaker <ilmari@ilmari.org>, 205361@bugs.debian.org
Resent-From: Dagfinn Ilmari Mannsaker <ilmari@ilmari.org>
Original-Sender: =?iso-8859-1?Q?Dagfinn_Ilmari_Manns=E5ker?=
	<ilmari@ilmari.org>
Resent-To: debian-bugs-dist@lists.debian.org
Resent-Cc: CDBS Hackers <build-common-hackers@lists.alioth.debian.org>
Resent-Date: Thu, 14 Aug 2003 08:33:01 UTC
Resent-Message-ID: <handler.205361.B.10608498429506@bugs.debian.org>
X-Debian-PR-Message: report 205361
X-Debian-PR-Package: cdbs
X-Debian-PR-Keywords: patch
Received: via spool by submit@bugs.debian.org id=B.10608498429506 (code B
	ref -1); Thu, 14 Aug 2003 08:33:01 UTC
Received: (at submit) by bugs.debian.org; 14 Aug 2003 08:30:42 +0000
Received: from krs-dhcp367.studby.uio.no (galadriel) [129.240.107.144]  by
	master.debian.org with esmtp (Exim 3.35 1 (Debian)) id 19nDVH-0002SW-00;
	Thu, 14 Aug 2003 03:30:39 -0500
Received: from ilmari by galadriel with local (Exim 3.36 #1 (Debian)) id
	19nDVF-0005UH-00; Thu, 14 Aug 2003 10:30:37 +0200
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ISO-8859-1"
From: Dagfinn Ilmari Mannsaker <ilmari@ilmari.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
X-Mailer: reportbug 2.22
Message-Id: <E19nDVF-0005UH-00@galadriel>
Delivered-To: submit@bugs.debian.org
Resent-Sender: Debian BTS <debbugs@master.debian.org>
Subject: [Build-common-hackers] Bug#205361: cdbs: perl modules should
	install into DEB_DESTDIR
Sender: build-common-hackers-admin@lists.alioth.debian.org
Errors-To: build-common-hackers-admin@lists.alioth.debian.org
X-BeenThere: build-common-hackers@lists.alioth.debian.org
X-Mailman-Version: 2.0.11
Precedence: bulk
List-Help:
	<mailto:build-common-hackers-request@lists.alioth.debian.org?subject=help>
List-Post: <mailto:build-common-hackers@lists.alioth.debian.org>
List-Subscribe:
	<http://lists.alioth.debian.org/mailman/listinfo/build-common-hackers>,
	<mailto:build-common-hackers-request@lists.alioth.debian.org?subject=subscribe>
List-Id: List for users and developers of CDBS
	<build-common-hackers.lists.alioth.debian.org>
List-Unsubscribe:
	<http://lists.alioth.debian.org/mailman/listinfo/build-common-hackers>,
	<mailto:build-common-hackers-request@lists.alioth.debian.org?subject=unsubscribe>
List-Archive:
	<http://lists.alioth.debian.org/pipermail/build-common-hackers/>
Date: Thu, 14 Aug 2003 10:30:37 +0200
X-Spam-Status: No, hits=-7.4 required=5.0
	tests=BAYES_01,KNOWN_MAILING_LIST,PATCH_UNIFIED_DIFF,
	PGP_SIGNATURE,UPPERCASE_25_50,X_LOOP autolearn=ham version=2.55
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)

Package: cdbs
Version: 0.4.5.2
Severity: normal
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The DEB_MAKEMAKER_PACKAGE variable is useless (and its setting in
perlmodule.mk doesn't work, ?= only sets if it's undefined, not if it's
empty). Also, the setting of it in perlmodule-vars.mk is broken, since
'list-pacakges same' doesn't return arch-all packages.

Instead, perl modules should be installed into DEB_DESTDIR and
debian/package.install should take care of putting it in the right
package for multi-binary packages.

This patch removes DEB_MAKEMAKER_PACKAGE and uses
$(DEB_DESTDIR)/usr for PREFIX in DEB_MAKE_INSTALL_TARGET.

- --- perlmodule.mk.orig	2003-08-09 06:10:25.000000000 +0200
+++ perlmodule.mk	2003-08-09 06:03:01.000000000 +0200
@@ -32,8 +32,6 @@
 
 include $(_cdbs_class_path)/makefile.mk$(_cdbs_makefile_suffix)
 
- -DEB_MAKEMAKER_PACKAGE ?= tmp
- -
 ifneq ($(DEB_BUILDDIR),$(DEB_SRCDIR))
 $(error DEB_BUILDDIR and DEB_SRCDIR must be the same for Perl builds.)
 endif
- --- perlmodule-vars.mk.orig	2003-08-09 05:56:08.000000000 +0200
+++ perlmodule-vars.mk	2003-08-09 06:03:49.000000000 +0200
@@ -33,16 +33,12 @@
 # Override optimizations to follow Perl Policy 3.3
 DEB_MAKE_INVOKE = $(DEB_MAKE_ENVVARS) make -C $(DEB_BUILDDIR) OPTIMIZE="$(CFLAGS)"
 
- -# If there are more than one package, simply install into the first one.
- -# Unset to install into debian/tmp instead.
- -DEB_MAKEMAKER_PACKAGE := $(strip $(shell $(_cdbs_scripts_path)/list-packages same))
- -
 DEB_MAKEMAKER_INVOKE = /usr/bin/perl Makefile.PL INSTALLDIRS=vendor
 
 # Set some MakeMaker defaults
 DEB_MAKE_BUILD_TARGET = all
 DEB_MAKE_CLEAN_TARGET = distclean
 DEB_MAKE_CHECK_TARGET = test
- -DEB_MAKE_INSTALL_TARGET = install PREFIX=$(CURDIR)/debian/$(DEB_MAKEMAKER_PACKAGE)/usr
+DEB_MAKE_INSTALL_TARGET = install PREFIX=$(DEB_DESTDIR)/usr
 
 endif


- -- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux galadriel 2.4.21-4-686 #1 Sat Aug 2 23:27:25 EST 2003 i686
Locale: LANG=en_US, LC_CTYPE=no_NO.ISO-8859-1

- -- no debconf information

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/O0itVcejModakHQRArxvAJ9deYIf1+He7D95/llVxkY5y4RFAQCgyET/
jRjbt6P9ZSsR7ZkzEp2ApOw=
=PI7y
-----END PGP SIGNATURE-----


_______________________________________________
Build-common-hackers mailing list
Build-common-hackers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/build-common-hackers


--=-ZFymPGmYv81qFdIiRBER--



