[Build-common-hackers] Bug#205361: marked as done (cdbs: perl modules should install into DEB_DESTDIR)
Debian Bug Tracking System
owner@bugs.debian.org
Sun, 31 Aug 2003 00:33:29 -0500
Your message dated Sun, 31 Aug 2003 01:26:32 -0400
with message-id <1062307592.6704.22.camel@columbia>
and subject line [Build-common-hackers] Bug#205361: cdbs: perl modules should install into DEB_DESTDIR
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 14 Aug 2003 08:30:42 +0000
>From ilmari@ilmari.org Thu Aug 14 03:30:39 2003
Return-path: <ilmari@ilmari.org>
Received: from krs-dhcp367.studby.uio.no (galadriel) [129.240.107.144]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 19nDVH-0002SW-00; Thu, 14 Aug 2003 03:30:39 -0500
Received: from ilmari by galadriel with local (Exim 3.36 #1 (Debian))
id 19nDVF-0005UH-00; Thu, 14 Aug 2003 10:30:37 +0200
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ISO-8859-1"
From: Dagfinn Ilmari Mannsaker <ilmari@ilmari.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: cdbs: perl modules should install into DEB_DESTDIR
X-Mailer: reportbug 2.22
Date: Thu, 14 Aug 2003 10:30:37 +0200
Message-Id: <E19nDVF-0005UH-00@galadriel>
Sender: =?iso-8859-1?Q?Dagfinn_Ilmari_Manns=E5ker?= <ilmari@ilmari.org>
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-16.4 required=4.0
tests=BAYES_01,HAS_PACKAGE,PATCH_UNIFIED_DIFF,PGP_SIGNATURE,
UPPERCASE_25_50
autolearn=ham version=2.53-bugs.debian.org_2003_07_20
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_07_20 (1.174.2.15-2003-03-30-exp)
Package: cdbs
Version: 0.4.5.2
Severity: normal
Tags: patch
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The DEB_MAKEMAKER_PACKAGE variable is useless (and its setting in
perlmodule.mk doesn't work, ?= only sets if it's undefined, not if it's
empty). Also, the setting of it in perlmodule-vars.mk is broken, since
'list-pacakges same' doesn't return arch-all packages.
Instead, perl modules should be installed into DEB_DESTDIR and
debian/package.install should take care of putting it in the right
package for multi-binary packages.
This patch removes DEB_MAKEMAKER_PACKAGE and uses
$(DEB_DESTDIR)/usr for PREFIX in DEB_MAKE_INSTALL_TARGET.
- --- perlmodule.mk.orig 2003-08-09 06:10:25.000000000 +0200
+++ perlmodule.mk 2003-08-09 06:03:01.000000000 +0200
@@ -32,8 +32,6 @@
include $(_cdbs_class_path)/makefile.mk$(_cdbs_makefile_suffix)
- -DEB_MAKEMAKER_PACKAGE ?= tmp
- -
ifneq ($(DEB_BUILDDIR),$(DEB_SRCDIR))
$(error DEB_BUILDDIR and DEB_SRCDIR must be the same for Perl builds.)
endif
- --- perlmodule-vars.mk.orig 2003-08-09 05:56:08.000000000 +0200
+++ perlmodule-vars.mk 2003-08-09 06:03:49.000000000 +0200
@@ -33,16 +33,12 @@
# Override optimizations to follow Perl Policy 3.3
DEB_MAKE_INVOKE = $(DEB_MAKE_ENVVARS) make -C $(DEB_BUILDDIR) OPTIMIZE="$(CFLAGS)"
- -# If there are more than one package, simply install into the first one.
- -# Unset to install into debian/tmp instead.
- -DEB_MAKEMAKER_PACKAGE := $(strip $(shell $(_cdbs_scripts_path)/list-packages same))
- -
DEB_MAKEMAKER_INVOKE = /usr/bin/perl Makefile.PL INSTALLDIRS=vendor
# Set some MakeMaker defaults
DEB_MAKE_BUILD_TARGET = all
DEB_MAKE_CLEAN_TARGET = distclean
DEB_MAKE_CHECK_TARGET = test
- -DEB_MAKE_INSTALL_TARGET = install PREFIX=$(CURDIR)/debian/$(DEB_MAKEMAKER_PACKAGE)/usr
+DEB_MAKE_INSTALL_TARGET = install PREFIX=$(DEB_DESTDIR)/usr
endif
- -- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux galadriel 2.4.21-4-686 #1 Sat Aug 2 23:27:25 EST 2003 i686
Locale: LANG=en_US, LC_CTYPE=no_NO.ISO-8859-1
- -- no debconf information
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
iD8DBQE/O0itVcejModakHQRArxvAJ9deYIf1+He7D95/llVxkY5y4RFAQCgyET/
jRjbt6P9ZSsR7ZkzEp2ApOw=
=PI7y
-----END PGP SIGNATURE-----
---------------------------------------
Received: (at 205361-done) by bugs.debian.org; 31 Aug 2003 05:30:12 +0000
>From walters@verbum.org Sun Aug 31 00:30:03 2003
Return-path: <walters@verbum.org>
Received: from monk.debian.net (monk.verbum.org) [216.226.142.128]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 19tKmp-0006xC-00; Sun, 31 Aug 2003 00:30:03 -0500
Received: from columbia (dhcp024-208-189-249.columbus.rr.com [24.208.189.249])
(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
(Client CN "columbia.verbum.org", Issuer "monk.verbum.org" (verified OK))
by monk.verbum.org (Postfix (Debian/GNU)) with ESMTP id 87A4F32A6BB
for <205361-done@bugs.debian.org>; Sun, 31 Aug 2003 01:30:36 -0400 (EDT)
Received: by columbia (Postfix, from userid 1000)
id 3EDFE26ECA8; Sun, 31 Aug 2003 01:26:32 -0400 (EDT)
Subject: Re: [Build-common-hackers] Bug#205361: cdbs: perl modules should
install into DEB_DESTDIR
From: Colin Walters <walters@verbum.org>
To: 205361-done@bugs.debian.org
In-Reply-To: <E19nDVF-0005UH-00@galadriel>
References: <E19nDVF-0005UH-00@galadriel>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1062307592.6704.22.camel@columbia>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.4
Date: Sun, 31 Aug 2003 01:26:32 -0400
Delivered-To: 205361-done@bugs.debian.org
X-Spam-Status: No, hits=-2.3 required=4.0
tests=BAYES_01,IN_REP_TO,REFERENCES,USER_AGENT_XIMIAN
version=2.53-bugs.debian.org_2003_8_27
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_8_27 (1.174.2.15-2003-03-30-exp)
This bug has been fixed in CVS since 0.4.5.4.