[Build-common-hackers] change to autotools-vars.mk

[Jeff Bailey]

--=-Fgq+Zjfy7tjIKEbY5mfw
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sun, 2003-06-15 at 03:24, Colin Walters wrote:
> I am concerned about this change to autotools-vars.mk:
>=20
> revision 1.5
> date: 2003/06/14 19:17:22;  author: jbailey;  state: Exp;  lines: +3 -3
> Don't clobber user settings for DEB_MAKE_INSTALL_TARGET, DEB_MAKE_CLEAN_T=
ARGET, and DEB_MAKE_CHECK_TARGET
>=20
> That effectively makes the variables in autotools-vars.mk do nothing,
> because they're all already set by makefile.mk.  I deliberately used :=3D
> there.=20
>=20
> This doesn't clobber user changes because users should be setting those
> variables (using :=3D) *below* the rule inclusion.  Please revert this
> change.

Oy.  That means we have some things that need to be set above, and
things that need to be set below?

I wonder whether they should be set in makefile.mk then.

I'm looking at the makefile.mk:
# This variable is deprecated.
DEB_BUILD_MAKE_TARGET ?=3D
# New in 0.2.8.
DEB_MAKE_BUILD_TARGET ?=3D $(DEB_BUILD_MAKE_TARGET)

DEB_MAKE_INSTALL_TARGET ?=3D

# This variable is deprecated.
DEB_CLEAN_MAKE_TARGET ?=3D clean
# New in 0.2.8.
DEB_MAKE_CLEAN_TARGET ?=3D $(DEB_CLEAN_MAKE_TARGET)

Why are these defined at all in makefile.mk?  They can just as easily be
left blank, which seems like it would solve this problem.  clean is
currently defined, but that's the same in autotools.mk

Tks,
Jeff Bailey

--=20
Breathe into my hands, I'll cup them like a glass to drink from...
 - Tattle Tale

--=-Fgq+Zjfy7tjIKEbY5mfw
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQA+7CSi5M5hmdCYCpkRArHEAJ9adaNInd36JZlc8bUU4O6VPnUEpACggSUA
4LIp9v46BDrw6Rs+wcCBLXg=
=9313
-----END PGP SIGNATURE-----

--=-Fgq+Zjfy7tjIKEbY5mfw--