[Build-common-hackers] Bug#242831: cdbs: should enforce quoting of debhelper args

[Andres Salomon]

Package: cdbs
Version: 0.4.21
Severity: minor 


Currently, debhelper.mk has the following line:

dh_installinit -p$(cdbs_curpkg) $(if
$(DEB_UPDATE_RCD_PARAMS),--update-rcd-params=$(DEB_UPDATE_RCD_PARAMS),$(if
$(DEB_UPDATE_RCD_PARAMS_$(cdbs_curpkg)),--update-rcd-params=$(DEB_UPDATE_RCD_PARAMS_$(cdbs_curpkg))))
$(DEB_DH_INSTALLINIT_ARGS)

This directly substitutes $DEB_UPDATE_RCD_PARAMS (and friends) into the
--update-rcd-params arg.  That works fine if the following is used:
DEB_UPDATE_RCD_PARAMS := "start 25 S ."
This is substituted, and dh_installinit --update-rcd-params="start 25 S ."
is run.

However, if it's not quoted, as in:
DEB_UPDATE_RCD_PARAMS := start 25 S .
Make still substitutes all the values, so cdbs ends up running
dh_installinit --update-rcd-params=start 25 S .
This is obviously incorrect; cdbs should enforce quoting.




-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.4-1-686
Locale: LANG=C, LC_CTYPE=C

-- no debconf information