[Build-common-hackers] Bug#235961: [PATCH] DEB_AUTO_UPDATE_AUTOMAKE -I m4 feature doesn't work

[Andreas Rottmann]

Package: cdbs
Version: 0.4.21
Severity: normal

This code (in autotools-files.mk) doesn't work properly:

	if test -n "$(DEB_AUTO_UPDATE_AUTOMAKE)" ; then \
		if test -d $(DEB_SRCDIR)/m4 ; then m4="-I m4" ; fi ; \
		if test -e $(DEB_SRCDIR)/aclocal.m4 ; then cd $(DEB_SRCDIR) && aclocal-$(DEB_AUTO_UPDATE_AUTOMAKE) $(m4) ; fi ; \
	fi

If you replace $(m4) with $$m4 (thus using the shell's expansion, not make's),
this is fixed:

	if test -n "$(DEB_AUTO_UPDATE_AUTOMAKE)" ; then \
		if test -d $(DEB_SRCDIR)/m4 ; then m4="-I m4" ; fi ; \
		if test -e $(DEB_SRCDIR)/aclocal.m4 ; then cd $(DEB_SRCDIR) && aclocal-$(DEB_AUTO_UPDATE_AUTOMAKE) $(m4) ; fi ; \
	fi

It might be a good idea to add a new variable, e.g. 
DEB_AUTO_UPDATE_ACLOCAL_FLAGS instead of relying on this heuristic, however.


Thanks, Andy

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.1-k7
Locale: LANG=C, LC_CTYPE=de_AT.UTF-8

-- no debconf information