[Build-common-hackers] Bug#235961: marked as done ([PATCH] DEB_AUTO_UPDATE_AUTOMAKE -I m4 feature doesn't work)

Debian Bug Tracking System owner@bugs.debian.org
Fri, 24 Sep 2004 15:18:06 -0700

Your message dated Fri, 24 Sep 2004 18:02:03 -0400
with message-id <E1CAy8h-0000tr-00@newraff.debian.org>
and subject line Bug#235961: fixed in cdbs 0.4.23-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

Received: (at submit) by bugs.debian.org; 3 Mar 2004 13:28:42 +0000
>From a.rottmann@gmx.at Wed Mar 03 05:28:42 2004
Return-path: <a.rottmann@gmx.at>
Received: from mail.gmx.de (mail.gmx.net) [] 
	by spohr.debian.org with smtp (Exim 3.35 1 (Debian))
	id 1AyWQU-0001bh-00; Wed, 03 Mar 2004 05:28:42 -0800
Received: (qmail 22917 invoked by uid 65534); 3 Mar 2004 13:28:08 -0000
Received: from chello212186006140.401.14.univie.teleweb.at (EHLO garibaldi) (
  by mail.gmx.net (mp017) with SMTP; 03 Mar 2004 14:28:08 +0100
X-Authenticated: #3102804
Received: from ivanova.rhinosaur.lan ([] helo=ivanova)
	by garibaldi with esmtp (Exim 4.30)
	id 1AyWPj-0008Nj-T1; Wed, 03 Mar 2004 14:27:55 +0100
Received: from andy by ivanova with local (Exim 4.30)
	id 1AyWPj-0002We-De; Wed, 03 Mar 2004 14:27:55 +0100
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Andreas Rottmann <rotty@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: [PATCH] DEB_AUTO_UPDATE_AUTOMAKE -I m4 feature doesn't work
X-Mailer: reportbug 2.49
Date: Wed, 03 Mar 2004 14:27:55 +0100
Message-Id: <E1AyWPj-0002We-De@ivanova>
Sender: Andreas Rottmann <a.rottmann@gmx.at>
X-Spam-Score: -4.9 (----)
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_01 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-2.4 required=4.0 tests=HAS_PACKAGE,UPPERCASE_25_50 
	autolearn=no version=2.60-bugs.debian.org_2004_03_01

Package: cdbs
Version: 0.4.21
Severity: normal

This code (in autotools-files.mk) doesn't work properly:

	if test -n "$(DEB_AUTO_UPDATE_AUTOMAKE)" ; then \
		if test -d $(DEB_SRCDIR)/m4 ; then m4="-I m4" ; fi ; \
		if test -e $(DEB_SRCDIR)/aclocal.m4 ; then cd $(DEB_SRCDIR) && aclocal-$(DEB_AUTO_UPDATE_AUTOMAKE) $(m4) ; fi ; \

If you replace $(m4) with $$m4 (thus using the shell's expansion, not make's),
this is fixed:

	if test -n "$(DEB_AUTO_UPDATE_AUTOMAKE)" ; then \
		if test -d $(DEB_SRCDIR)/m4 ; then m4="-I m4" ; fi ; \
		if test -e $(DEB_SRCDIR)/aclocal.m4 ; then cd $(DEB_SRCDIR) && aclocal-$(DEB_AUTO_UPDATE_AUTOMAKE) $(m4) ; fi ; \

It might be a good idea to add a new variable, e.g. 
DEB_AUTO_UPDATE_ACLOCAL_FLAGS instead of relying on this heuristic, however.

Thanks, Andy

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.1-k7
Locale: LANG=C, LC_CTYPE=de_AT.UTF-8

-- no debconf information

Received: (at 235961-close) by bugs.debian.org; 24 Sep 2004 22:08:09 +0000
>From katie@ftp-master.debian.org Fri Sep 24 15:08:09 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CAyEb-00008Y-00; Fri, 24 Sep 2004 15:08:09 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1CAy8h-0000tr-00; Fri, 24 Sep 2004 18:02:03 -0400
From: Jeff Bailey <jbailey@raspberryginger.com>
To: 235961-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#235961: fixed in cdbs 0.4.23-1
Message-Id: <E1CAy8h-0000tr-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Fri, 24 Sep 2004 18:02:03 -0400
Delivered-To: 235961-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25

Source: cdbs
Source-Version: 0.4.23-1

We believe that the bug you reported is fixed in the latest version of
cdbs, which is due to be installed in the Debian FTP archive:

  to pool/main/c/cdbs/cdbs_0.4.23-1.dsc
  to pool/main/c/cdbs/cdbs_0.4.23-1.tar.gz
  to pool/main/c/cdbs/cdbs_0.4.23-1_all.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 235961@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Jeff Bailey <jbailey@raspberryginger.com> (supplier of updated cdbs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Fri, 24 Sep 2004 13:34:28 -0400
Source: cdbs
Binary: cdbs
Architecture: source all
Version: 0.4.23-1
Distribution: unstable
Urgency: low
Maintainer: CDBS Hackers <build-common-hackers@lists.alioth.debian.org>
Changed-By: Jeff Bailey <jbailey@raspberryginger.com>
 cdbs       - common build system for Debian packages
Closes: 235961 265562 266982 267254 268483 272758
 cdbs (0.4.23-1) unstable; urgency=low
   * Thanks to Robert Millan for the NMU's!
     Acknowledging: (Closes: #235961, #268483, #265562, #266982, #267254)
   * Apply Robert's patch to generate config's from config.in.
     (Closes: #272758).  Further tweaked to honour debian/control as a
     target, and to make sure that cdbs doesn't depend on cdbs.
   * Use this new feature in CDBS.
 4ec70c08c8df904f703c1740edf72c71 854 devel optional cdbs_0.4.23-1.dsc
 d27992e27edfe256e40b3c1e5ac1a163 210423 devel optional cdbs_0.4.23-1.tar.gz
 92a7448440bc26ea2807845ec654a6cc 61194 devel optional cdbs_0.4.23-1_all.deb

Version: GnuPG v1.2.5 (GNU/Linux)