[Build-common-hackers] Bug#294694: cdbs: simple-patchsys.mk breaks if it can't find patches

Andres Salomon Andres Salomon <dilinger@voxel.net>, 294694@bugs.debian.org
Fri, 11 Feb 2005 01:18:19 -0500

Package: cdbs
Version: 0.4.26-4
Severity: normal


If simple-patchsys.mk is included, and debian/patches doesn't exist (or
is empty), the build just hangs.  You can see the cause of the hang

19608 pts/13   S+     0:00 /usr/bin/make -f debian/rules clean
19638 pts/13   S+     0:00 /bin/sh -c if lsdiff=`which lsdiff` ; then
$lsdiff -H  | egrep "/config\.(guess|sub|rpath)$" | tr "\n" " " ; fi
19641 pts/13   S+     0:00 /usr/bin/lsdiff -H
19642 pts/13   S+     0:00 grep -E /config\.(guess|sub|rpath)$
19643 pts/13   S+     0:00 tr \n

The DEB_PATCHES variable ends up being empty, which means that
  $$lsdiff -H $(DEB_PATCHES) 
ends up being `/usr/bin/lsdiff -H`, which simply hangs.  This definitely
should not end up in sarge.  One can fix it by adding a patch to
debian/patches, or commenting out the simple-patchsys.mk line.  Of
course, when someone updates their package to a new upstream version,
deleting merged patches, and then discovers that the package no longer
builds, they may not realize this immediately.  :)

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.10-1-686m
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

-- no debconf information