[Build-common-hackers] Bug#316034: cdbs: build-essential added to Build-Depends

[Arjan Oosting]

This is a multi-part MIME message sent by reportbug.

--===============0656200471==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: cdbs
Version: 0.4.30
Severity: normal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Recently CDBS started adding build-essential to the Build-Depends line of debian/control when using
DEB_AUTO_UPDATE_DEBIAN_CONTROL. Unversioned build dependencies on build-essential are not allowed by 
the Debian policy, see discussion on .....

If I look at the code of CDBS it seems that CDBS tries to remove build-essential from the list 
but that this fails (see code snippit below), because in buildvars.mk the build dependency to 
cdbs is put in front of build-essential in stead of after it. The attached patch will fix this.

        sed \
                -e "s/@cdbs@/$(CDBS_BUILD_DEPENDS)/g" \
                -e "s/^Build-Depends\(\|-Indep\): build-essential, /Build-Depends\1: /g" \
                \
                -e "s/^Cpu: .*/Architecture: $(control_arch)/g" \
                -e "/^System: /d" \
                \
                -e "s/\[cpu: \([^]]*\)\]/\[\`type-handling \\\\\`echo \1 | tr ' ' ','\\\\\` any\`\]/g" \
                -e "s/\[system: \([^]]*\)\]/\[\`type-handling any \\\\\`echo \1 | tr ' ' ','\\\\\`\`\]/g" \
                \
                -e "s/\"/\\\\\"/g" \
                -e "s/^/echo \"/g" \
                -e "s/\\$$/\\\\$$/g" \
                -e "s/$$/\"/g" \
        < debian/control.in | $(SHELL) > debian/control
        -dpkg-checkbuilddeps -B

Greetings Arjan Oosting

- -- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'testing-proposed-updates'), (500, 'unstable'), (102, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.11-2-stardust
Locale: LANG=nl_NL.UTF-8@euro, LC_CTYPE=nl_NL.UTF-8@euro (charmap=UTF-8)

cdbs depends on no packages.

Versions of packages cdbs recommends:
ii  autotools-dev                 20050422.1 Update infrastructure for config.{
ii  debhelper                     4.9.1      helper programs for debian/rules

- -- no debconf information

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCwMXfUALvsZYuOJARAu3FAJ4oAaicYg+lJiejX75FAosfylhlkQCgzglE
8EAYhyI/aq54WVg9hmaVWGE=
=BTrG
-----END PGP SIGNATURE-----

--===============0656200471==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="cdbs.patch"

diff -Naur orig/cdbs-0.4.30/1/rules/buildvars.mk.in cdbs-0.4.30/1/rules/buildvars.mk.in
--- orig/cdbs-0.4.30/1/rules/buildvars.mk.in	2005-05-18 11:27:58.000000000 +0200
+++ cdbs-0.4.30/1/rules/buildvars.mk.in	2005-06-28 05:32:08.000000000 +0200
@@ -78,7 +78,7 @@
 CDBS_BUILD_DEPENDS	?= build-essential
 
 ifeq ($(_cdbs_bootstrap), )
-CDBS_BUILD_DEPENDS	:= cdbs (>= 0.4.23-1.1), $(CDBS_BUILD_DEPENDS)
+CDBS_BUILD_DEPENDS	:= $(CDBS_BUILD_DEPENDS), cdbs (>= 0.4.23-1.1)
 endif
 
 endif

--===============0656200471==--