[Build-common-hackers] Bug#294694: marked as done (cdbs: simple-patchsys.mk breaks if it can't find patches)

Debian Bug Tracking System owner@bugs.debian.org
Wed, 18 May 2005 03:03:20 -0700

Your message dated Wed, 18 May 2005 11:59:47 +0200
with message-id <20050518095947.GA27642@aragorn>
and subject line fixed
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

Received: (at submit) by bugs.debian.org; 11 Feb 2005 06:18:23 +0000
>From dilinger@voxel.net Thu Feb 10 22:18:23 2005
Return-path: <dilinger@voxel.net>
Received: from cpe-24-194-62-26.nycap.res.rr.com (spiral.voxel.net) [] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CzU8F-0001J2-00; Thu, 10 Feb 2005 22:18:23 -0800
Received: by spiral.voxel.net (Postfix, from userid 1000)
	id F3009F403B; Fri, 11 Feb 2005 01:18:19 -0500 (EST)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Andres Salomon <dilinger@voxel.net>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: cdbs: simple-patchsys.mk breaks if it can't find patches
X-Mailer: reportbug 3.7.1
Date: Fri, 11 Feb 2005 01:18:19 -0500
Message-Id: <20050211061819.F3009F403B@spiral.voxel.net>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

Package: cdbs
Version: 0.4.26-4
Severity: normal


If simple-patchsys.mk is included, and debian/patches doesn't exist (or
is empty), the build just hangs.  You can see the cause of the hang

19608 pts/13   S+     0:00 /usr/bin/make -f debian/rules clean
19638 pts/13   S+     0:00 /bin/sh -c if lsdiff=`which lsdiff` ; then
$lsdiff -H  | egrep "/config\.(guess|sub|rpath)$" | tr "\n" " " ; fi
19641 pts/13   S+     0:00 /usr/bin/lsdiff -H
19642 pts/13   S+     0:00 grep -E /config\.(guess|sub|rpath)$
19643 pts/13   S+     0:00 tr \n

The DEB_PATCHES variable ends up being empty, which means that
  $$lsdiff -H $(DEB_PATCHES) 
ends up being `/usr/bin/lsdiff -H`, which simply hangs.  This definitely
should not end up in sarge.  One can fix it by adding a patch to
debian/patches, or commenting out the simple-patchsys.mk line.  Of
course, when someone updates their package to a new upstream version,
deleting merged patches, and then discovers that the package no longer
builds, they may not realize this immediately.  :)

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.10-1-686m
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

-- no debconf information

Received: (at 294694-done) by bugs.debian.org; 18 May 2005 09:59:27 +0000
>From rmh@debian.org Wed May 18 02:59:26 2005
Return-path: <rmh@debian.org>
Received: from 216.red-62-57-140.user.auna.net (aragorn) [] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DYLKo-0007fv-00; Wed, 18 May 2005 02:59:26 -0700
Received: from rmh by aragorn with local (Exim 4.50)
	id 1DYLL9-0007Bw-Bp
	for 294694-done@bugs.debian.org; Wed, 18 May 2005 11:59:47 +0200
Date: Wed, 18 May 2005 11:59:47 +0200
From: Robert Millan <rmh@debian.org>
To: 294694-done@bugs.debian.org
Subject: fixed
Message-ID: <20050518095947.GA27642@aragorn>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Sender: Robert Millan <rmh@debian.org>
Organisation: free as in freedom
User-Agent: Mutt/1.5.9i
Delivered-To: 294694-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-2.0 required=4.0 tests=BAYES_00,ONEWORD autolearn=no 

I don't know when this happened, but looks like this patch is already applied.

I'm closing this bug.

 .''`.   Proudly running Debian GNU/kFreeBSD unstable/unreleased (on UFS2+S)
: :' :
`. `'    http://www.debian.org/ports/kfreebsd-gnu