[Build-common-hackers] Bug#372682: cdbs: Hides errors when reversing patches fails

[Sam Morris]

Package: cdbs
Version: 0.4.40
Severity: important

For some reason patch is failing to reverse a patch when cleaning the source of a
package I am working on:

patches: debian/patches/100_use_lua50.patch debian/patches/150_autoreconf.patch debian/patches/200_log_to_home_dir.patch
Trying reversed patch debian/patches/200_log_to_home_dir.patch at level 1...success.
Trying reversed patch debian/patches/150_autoreconf.patch at level 1...0...2.../bin/sh: line 23:  2832 Done                    $cat $patch
      2833 Aborted                 | patch -d . $reverse -E --dry-run -p$level >$logfile 2>&1
failure (ignored).
Trying reversed patch debian/patches/100_use_lua50.patch at level 1...success.

CDBS should not ignore this failure! It should have caused an error
while cleaning the source.

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (530, 'testing'), (520, 'unstable'), (510, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16-2-k7
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)

cdbs depends on no packages.

Versions of packages cdbs recommends:
ii  autotools-dev                 20060223.1 Update infrastructure for config.{
ii  debhelper                     5.0.35     helper programs for debian/rules

-- no debconf information