[Build-common-hackers] Bug#374809: cdbs: updated python class needed to achieve the transition

Peter Eisentraut peter_e at gmx.net
Sat Jun 24 07:35:40 UTC 2006

Marc Dequènes wrote:
> No, tomorrow is in half an hour in DL time, this is too late, i need to
> go to bed quickly, so here it is.

Some technical comments then:

Variable assignments that use the $(shell) function should be done using
:= for performance reasons.

Use of the [[ ]] shell operator strikes me as unusual.  Why not [ ] ?

You seem to have an encoding problem in this line:

    +# check if build is possible

I'm not a fan of this:

+       echo "$(cdbs_pycompat)" >debian/pycompat

People should write the desired value into the file themselves.  We have
no business messing with that.

More information about the Build-common-hackers mailing list