[Build-common-hackers] Bug#410088: Spurious dh_clean in debhelper.mk breaks builds with DEB_BUILDDIR := debian/tmp

[Loïc Minier]

Package: cdbs
Version: 0.4.48
Severity: important

        Hi,

 For some reason, debhelper.mk has a dh_clean call in
 common-install-prehook::.  This seems to be completely spurious and I
 do not understand the need for such a call.  What I did see is that it
 causes gtk2-engines to be built twice; the sequence of events is as
 follow:
 dpkg-buildpackage calls debian/rules build
   build depends on a target which calls ./configure from debian/tmp/x11 if config.status is missing
     ./configure creates config.status
   build depends on a target which calls make from debian/tmp/x11
     make builds the binaries
 dpkg-buildpackage calls debian/rules binary
   binary depends on common-install-prehook-impl which calls dh_clean
     dh_clean removes debian/tmp/x11
   binary depends on a target which calls ./configure from debian/tmp/x11 if config.status is missing
     ./configure creates config.status again


 I think you can reproduce this with:
    DEB_BUILDDIR := debian/tmp/build

 BTW, gtk2-engines is currently built in two flavors, so 4 ./configure +
 make, but I don't think this is connected.

 Since this dh_clean is as old as the first debhelper.mk that CVS knows
 about, I think it might simply be superfluous. :)

   Bye,

-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-4-686
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)

cdbs depends on no packages.

Versions of packages cdbs recommends:
ii  autotools-dev                 20060920.1 Update infrastructure for config.{
ii  debhelper                     5.0.42     helper programs for debian/rules

-- no debconf information

-- 
Loïc Minier <lool at dooz.org>