[Build-common-hackers] Bug#489430: Bug#489430: Bug#489430: cdbs: debhelper usage

[Jonas Smedegaard]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, Jul 07, 2008 at 01:25:38PM +0200, Peter Eisentraut wrote:
>Am Samstag, 5. Juli 2008 schrieb Martin Koeppe:
>> See package time 1.7-21 as example. Its rules says:
>>
>>    include /usr/share/cdbs/1/class/autotools.mk
>>    include /usr/share/cdbs/1/rules/debhelper.mk
>>
>> i.e. debhelper.mk is included after autotools.mk. In this
>> configuration buildcore.mk doesn't know that debhelper is to use and
>> so doesn't use dh_testroot.
>
>It is documented that you should include debhelper.mk first.  If you 
>don't, things will degrade, albeit smoothly.  I don't know if there is 
>anything more we need to do about it.

Conditionals (like ifdef) are evaluated earlier than functions (like 
$(if ) ).

I have now committed a change to SVN to use only functions (not 
conditional) so the evaluation is done after file inclusion, and changed 
the variable from "simply expanded" (:=) to "recursively expanded" (=), 
to postpone resolving until actually used.

This has the drawback of executing the command every time it is used 
rather than only once, but I consider that acceptable.


  - Jonas

- -- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  - Enden er nær: http://www.shibumi.org/eoti.htm
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkh47W0ACgkQn7DbMsAkQLhqlQCdEemAF2hbMmo3ZaYk2KXvlJLR
SEgAnjJvBWjmaoVa7FQMSYbPR/BP4MPe
=3ngL
-----END PGP SIGNATURE-----