[Build-common-hackers] Bug#473381: cdbs: patchsys-quilt.mk should follow quilt convention

[Raphael Hertzog]

Package: cdbs
Version: 0.4.51
Severity: normal

Since quilt uses the "patches" directory by default, patchsys-quilt.mk
creates a symlink patches -> debian/patches/. This is the wrong way to do
it IMO.

You should have a behaviour similar to the what quilt recommends: see the
/usr/share/quilt/quilt.make file. It calls quilt that way:
QUILT_PATCHES=$(QUILT_PATCH_DIR) quilt --quiltrc /dev/null push -a || test $$? = 2

It's better since:
- the user configuration doesn't mess up with the behaviour of the build
  (which in itself warrants an important bug IMO)
- it doesn't create a useless symlink (see how this symlink can create
  problems in some unexpected way when trying to convert a package to
  using a new source package format:
  http://lists.debian.org/debian-dpkg/2008/03/msg00195.html)

Thanks for your work.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=POSIX, LC_CTYPE=POSIX (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages cdbs depends on:
ii  debhelper                     6.0.10     helper programs for debian/rules

Versions of packages cdbs recommends:
ii  autotools-dev                 20080123.1 Update infrastructure for config.{

-- no debconf information