[Build-common-hackers] Bug#439717: Bug#439717: Bug#439717: dh_desktop: no patch needed

[Jonas Smedegaard]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, Apr 06, 2009 at 09:09:28PM -0400, Jay Berkenbilt wrote:
>Jonas Smedegaard <dr at jones.dk> wrote:
>
>> On Mon, Apr 06, 2009 at 07:50:40PM -0400, Jay Berkenbilt wrote:
>>>
>>>Looking into this further, I believe no patch to cdbs is required. 
>>>Simply including /usr/share/cdbs/1/class/gnome.mk sometime after 
>>>including /usr/share/cdbs/1/rules/debhelper.mk appears to be 
>>>sufficient to cause dh_desktop to be run at the correct time.  At 
>>>least for my package, this is sufficient to remove the lintian 
>>>warning.
>>
>> Hm.  If you won't do it then I will: It is wrong to require a 
>> specific order of including the CDBS snippets, if at all possible to 
>> avoid it.
>>
>>
>> Thanks for raising attention to the issue, even if you do not see it 
>> as relevant to fix it (properly). :-)
>
>Actually, I didn't really check carefully about the order.  The order
>may not matter.  I didn't have gnome.mk included at all, so I figured
>the problem was just my omission.  However, I see code in gnome.mk
>that is conditional inside of
>
>ifdef _cdbs_rules_debhelper
>...
>endif
>
>which is most likely order-dependent since the ifdef will be evaluated 
>at the time that the file is loaded rather than at the time that the 
>rules are evaluated as with ordinary macros.

Yes, that indeed sounds like order-dependent.  Many places in the CDBS 
code has such without being strictly needed.  I want to clean that up - 
I apologize if I am now stealing your attention from something related 
but slightly different: I just really would appreciate help :-)


>Anyway, if you'd still like me to patch, I can still look into it.  I
>wasn't trying to punt it...just thinking that the error was actually
>in my rules rather than in cdbs. :-)  However, I won't have another
>chance to look at it until at least the weekend.

Yes, please.  If I can persuade you to cook up a patch then please do.  
Just take your time.


Another thought (but please note that I still haven't looked looked 
closely at this bugreport - am just replying to your recent messages): 
If it is safe to always run dh_debhelper (e.g. it does not require new 
dependencies) then perhaps it should be added to debhelper.mk (and 
dropped from gnome.mk if that snippet depend on debhelper).  My 
reasoning here is that I suspect desktop files are not GNOME-specific, 
so should be equally easy handled for other desktops too.


Thanks,

  - Jonas

- -- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAknbBdUACgkQn7DbMsAkQLjwaQCfXzhHC/+LRguBT9vK+JK0M34v
LoIAmgI0HgI4nJE2zqSVDtI4nhgZNmd2
=zsPg
-----END PGP SIGNATURE-----