[Build-common-hackers] Bug#523642: Bug#523642: overrides CFLAGS too agressively

[Jonas Smedegaard]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

package cdbs
tags 523642 wontfix
thanks


Hi Robert,

On Sat, Apr 11, 2009 at 05:35:26PM +0200, Robert Millan wrote:
>CFLAGS are overriden too agressively.  Some packages have very specific 
>requirements when it comes to CFLAGS, and its upstream Makefiles will 
>know better.

>Passing CFLAGS as argument makes it cumbersome to override, and removes 
>this flexibility (either we override or we don't).  I think it's much 
>better to pass those as environment variables.

Thanks for your bugreport.  Your argument makes sense in principle.

Unfortunately, CDBS is already in wide use with a different behaviour, 
and chaning this now has a high risk of causing surprises for some of 
those.

Personally I expect CDBS to forcefully tighten CFLAGS by default to the 
ones used by default in Debian (i.e. favoring Debian over upstream), and 
if in some odd case I really need upstream CFLAGS, I am well aware that 
I will need to readd them.

I would expect other CDBS users to handle it similarly.

I do not say that CDBS is correct or not in its current behaviour, just 
that it has a well defined vurrent behaviour that users rely on (whether 
or not they are aware of it).

I have tagged this as wontfix for that reason.  Please note that even if 
this means I do not expect this to change (or at least not soon - it is 
possible to change when we decide to bump ABI at some point, if ever), I 
am still interested in discussing it!


Could you perhaps provide some good examples of upstream software 
needing custom CFLAGS that is cumbersome to work around using CDBS?

Or is it that you would want to apply CDBS blindly to upstream packages 
(e.g. automated across many upstreams) and not _need_ to do any 
adjustments, even relatively simple ones, for upstreams with odd CFLAGS 
needs?

Please elaborate...


Kind regards,

  - Jonas

- -- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkngwcYACgkQn7DbMsAkQLhOnQCdEAKHk62ZKfQ9/v6J+AC8jKSm
Lr8AoJkomoJZYYZ6zYL15pNR+O1gXcEQ
=EfSJ
-----END PGP SIGNATURE-----