[Build-common-hackers] Bug#537497: Bug#537497: misc fixes/improvements in aclocal invocation

Jonas Smedegaard dr at jones.dk
Wed Aug 26 22:09:48 UTC 2009


package cdbs
tags 537497 pending
thanks


Hi Robert,

On Sat, Jul 18, 2009 at 09:14:36PM +0000, Robert Millan wrote:
>  - Move "-I m4" stanza to DEB_ACLOCAL_ARGS.  Behaviour is equivalent,
>    but it allows user to override it (e.g. if a different dir is desired).
>
>  - Truncate aclocal line.  The last bits were unnecessary due to
>    DEB_AUTO_UPDATE_ACLOCAL initialization (above in this file).
>
>  - Introduce DEB_ACLOCAL_ARGS in the aclocal invocation line.

Thanks!  Applied now in SVN, pending next packaging release.


>+ifneq (, $(wildcard $(DEB_SRCDIR)/m4))
>+DEB_ACLOCAL_ARGS ?= -I m4
>+endif

I changed above to the below, to allow setting DEB_SRCDIR after 
including cdbs files.

+DEB_ACLOCAL_ARGS ?= $(if $(wildcard $(DEB_SRCDIR)/m4)),-I m4)


Generally ifdef's should be avoided whenever possible, as they are 
resolved early on.


Kind regards,

  - Jonas

-- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20090827/5c7a0921/attachment.pgp>


More information about the Build-common-hackers mailing list