[Build-common-hackers] Bug#205395: Bug#205395: DEB_BUILD_DEPENDENCIES still not overwriteable

[Jonas Smedegaard]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Fri, Jul 10, 2009 at 07:22:58PM +0200, Joachim Breitner wrote:
>Am Freitag, den 10.07.2009, 16:39 +0200 schrieb Jonas Smedegaard:
>> On Fri, Jul 10, 2009 at 12:07:46PM +0200, Joachim Breitner wrote:
>> >setting DEB_BUILD_DEPENDENCIES in debian/rules still does not work. 
>> >I think you need to change
>> >DEB_BUILD_DEPENDENCIES = build-arch build-indep
>> >to
>> >DEB_BUILD_DEPENDENCIES ?= build-arch build-indep
>> >in /usr/share/cdbs/1/rules/buildcore.mk
>>
>> Thanks for noticing.
>>
>> It seems to me that you are partially right - if 
>> DEB_BUILD_DEPENDENCIES is set _above_ inclusion of cdbs snippets then 
>> it gets overridden.
>>
>> Could you please test if it works if you set DEB_BUILD_DEPENDENCIES 
>> _below_ inclusion of cdbs snippets?
>>
>> Also, what is your use case for setting this?  (just curious - you 
>> need not comment on this part).
>
>I tried both. I think the variable is expanded the moment it occurs on 
>the dependency line of a rule, thus exactly at the next after the 
>variable is set. Thus if I put the variable in front, it will be 
>overriden, and if I put it afterwards, the wrong value was already 
>expanded.
>
>The problem I want to solve is that, although cdbs follows policy here, 
>reality is that "dpkg-buildpackage -B" calls "build" (not 
>"build-arch"), and I don’t want to run the build-indep stuff in this 
>case.

Arrrgh, you are right: variables used in build targets are expanded 
early :-(

We should probably, in addition to changing to ?= as you propose, also 
document that DEB_BUILD_DEPENDENCIES is supported only _before_ 
including any cdbs snippets (as most if not all of them pulls in 
buildcore.mk).

Could you please test (if you haven't already) that your intended 
behaviour succeeds when hacking /usr/share/cdbs/1/rules/buildcore.mk 
directly to use =? at line 167 as proposed?


Kind regards,

  - Jonas

- -- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQIcBAEBCgAGBQJKV4ALAAoJECx8MUbBoAEh4EYP/iMlIvU5NfEMdWpTu+Xx0pnT
0z1Chd7LQyQ5MzlDWgid1cLuKz5qBpeWlCBvbpWfOdYOFRC/8WDhnRFNN/WlWHVJ
jRcDao35CE/L4PtTuKCfKd4oxgH8YwVqMc8J/B8ZIPfl3HaVB11lTYfxtBvo+4V+
W4Mpycaw3HDAdAkJ5VU+m+qoc1ww59T/MFI18oFrBqLpldBnJnof+sOQnf4GjFLQ
1O41W51UVHDW8HJYWeJVzsYy69RYK1GnD2ceWx4q/mHYks8JFwrjIUZJ//xKKgug
5kDNW2HDAoGd+enGUtQAZN0sJUhP+D+ifiUZAhZr9D4RgLWl6Kw8NX6sxSjvaiCq
VKAVC4IS7141RQVGX6e/buwKCrCpUp1XJ6ogKUBnUb1x8fpEnQScau6ic1D4OqcB
oqe1qMNYem4eMwohnxmIFWDfT6G+BL3KUfauCwUQ4wNjoFoAw54qrXwVnNoLGLqN
mdDsh7z6BPvjkRK2jQ9n6ONnQqxZK58B3Ms/PAaH54eguBejBozd7Yudo7caNJ0Z
wbUfjwsaVdatIfs10CCT27uWd/kEGaqyVaownyXbVASA8Gxqab+rpuGAtDXuVIvX
CaRpMz25lhwzSirJ0+InINhoVcsepkwgcNAKr+LEuue03BLN4IORLDMm1m1mGFBe
iZMAyj0ZP1KzfPswu98h
=Zals
-----END PGP SIGNATURE-----