[Build-common-hackers] Bug#521711: Bug#521711: cdbs: Clean target is misordered when using cmake class.

[Jonas Smedegaard]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun, Mar 29, 2009 at 06:25:25PM +0200, Raúl Sánchez Siles wrote:
>When calling clean target, the clean sequence looks wrong. This is an except:
[snip]
>  So what's happening is that makefile.mk makefile-clean target is 
>being added to clean target and this target is being called after 
>cleanbuilddir, unfortunately too late.
>IMHO, makefile-clean should be invoked before cleanbuilddir, or as the 
>first action of cleanbuilddir
>
>  I'm not sure how to proceed in this case, because I don¡'t think it's 
>feasible redefining clean target in buildcore.mk
>A possible solution would be redifining cleanbuilddir in cmake.mk like 
>this:
>
>cleanbuilddir:: makefile-clean
>	-$(if $(call cdbs_streq,$(DEB_BUILDDIR),$(DEB_SRCDIR)),,rm -rf 
>$(DEB_BUILDDIR))
>
>  Not sure is this is sensible though. Hope you have better ideas.

It seems to me that it is better to fix it within makefile.mk itself, 
like this:

cleanbuilddir:: makefile-clean
makefile-clean::

I.e. replace "clean::" with cleanbuilddir::".


Could you please test i that solves the specific case of yours, and 
shout it you spot errors in it.


Kind regards,

  - Jonas

- -- 
* Jonas Smedegaard - idealist og Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAknPrn4ACgkQn7DbMsAkQLi94gCeMeiTovLulG59DYLzRFc232HX
DEkAnRhJt2j+53yegOUkCSOONmc49pIl
=AMFq
-----END PGP SIGNATURE-----