[Build-common-hackers] Using CDBS' flavors mechanism to build packages

[Emilio Pozuelo Monfort]

On 19/12/10 12:26, Emilio Pozuelo Monfort wrote:
> On 19/12/10 03:15, Jonas Smedegaard wrote:
>> On Sun, Dec 19, 2010 at 01:47:48AM +0000, Emilio Pozuelo Monfort wrote:
>>> - Currently I need to manually specify the install directory this way:
>>> DEB_MAKE_DESTDIRSKEL = $(CURDIR)/debian/tmp/@FLAVOR@
>>> DEB_DESTDIR = $(CURDIR)/debian/tmp/$(cdbs_make_curflavor)/
>>> Would be nice if that was not necessary (or not that complicated).
>>
>> Please elaborate. What goes wrong if using the default values?
>
> It installs in debian/tmp//usr (see the double slash), so all the
> flavours end up in the same directory. That's when I don't specify
> DEB_MAKE_DESTDIRSKEL or DEB_DESTDIR.
>
> Being able to specify the DESTDIR for all the flavours and for some in
> particular would be great, e.g.
>
> DEB_DESTDIR = debian/tmp
> DEB_DESTDIR_udeb = debian/tmp/udeb
>
> This would partly solve my dh_install issue.

I'm now doing

DEB_DESTDIR = $(CURDIR)/debian/tmp$(if $(findstring 
udeb,$(cdbs_make_curflavor)),/udeb)

Without setting DEB_MAKE_DESTDIRSKEL. It's working great and the dh_install 
issue only affects libvte9-udeb.install, so it's not a big deal.

Note that DEB_MAKE_DESTDIRSKEL is set in makefile-vars.mk but is not used 
anywhere (unlike DEB_MAKE_BUILDDIRSKEL). Should it be used to set 
cdbs_make_curdestdir in makefile.mk ?

>>> - Would be useful to be able to specify CFLAGS as CFLAGS_$(flavor),
>>> the same way as we do with DEB_CONFIGURE_FLAGS_$(flavor). Probably
>>> other variables like LDFLAGS, etc.
>>
>> Yes. I'll look into that.
>
> Cool, thanks.

Alternatively I guess I could probably do something like

CFLAGS += $(if $(findstring udeb,$(cdbs_make_curflavor)),-Os)

though CFLAGS_flavor sounds more user friendly :)

Attached my current debian/rules, and a patch against git master to make it work.

Cheers,
Emilio

PS: I've subscribed to the list, no need to CC me either ;)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: rules
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20101219/dbfe2c7c/attachment.asc>