[Build-common-hackers] Bug#606703: Bug#606703: gnome.mk: invoke dh_girepository if available

[Emilio Pozuelo Monfort]

On 24/12/10 04:07, Jonas Smedegaard wrote:
> On Sat, Dec 11, 2010 at 01:43:22AM +0100, Emilio Pozuelo Monfort wrote:
>> dh_girepository is a helper to generate dependencies for gobject-introspection
>> packages (named gir1.*). It would be nice if it was called from gnome.mk so we
>> don't need to add that snipped to our debian/rules in every package.
>
> Hmm - would there be any harm in always running it in debhelper.mk?

I was thinking the same after creating the patch, debhelper.mk makes more sense. 
But we should apply this after squeeze is released, since dh_girepository 
enforces the gir policy and fails if it's not followed (the version in unstable 
shouldn't cause FTBFS on any packages, but better safe than sorry).

> It seems wrong to apply it to gnome.mk IMO. Actually, gnome.mk and kde.mk are
> some of the least maintained parts of CDBS - would be great to coordinate with
> the respective teams to ensure it actually does what they would expect from it.

I'll have a look at gnome.mk and its bug reports and keep an eye on it, since 
I'm part of pkg-gnome.

> Oh, and you made a typo in the patch: dh_girespository (sp in the middle).

Thanks, will fix before pushing.

Cheers,
Emilio