[Build-common-hackers] CFLAGS_$(flavor)

[Jonas Smedegaard]

On Mon, Dec 27, 2010 at 03:40:35PM +0000, Emilio Pozuelo Monfort wrote:
>On 24/12/10 04:01, Jonas Smedegaard wrote:
>> But I just rewrote CFLAGS handling earlier today, so maybe it broke 
>> in new ways ;-)
>>
>> Have a look at the files in git.
>>
>> I will too - and see if I can sneak in support for per-flavor CFLAG 
>> while still support that new non-intrusive CFLAGS handling by 
>> default.
>
>I tried with latest git and CFLAGS_udeb didn't work. Maybe we should 
>expand CFLAGS to CFLAGS_$(cdbs_curpkg) if that's set in 
>autotools-vars.mk

Sorry - I released without improving the CFLAGS handling further: 0.4.90 
supports neither per-package nor per-flavor variants.


>I'll upload gvfs with the CFLAGS = $(if $(findstring...) hack soon, and 
>remove the hack when we fix it.

It is recommended to extend (+=) rather than override (:= or =) if 
possible to allow dpkg-buildflags manipulation too (which was the reason 
for the newest CFLAGS changes).


>I've also converted glib2.0 and it works quite well with 0.4.90, no 
>hacks needed :)

Great!


  - Jonas

-- 
  * Jonas Smedegaard - idealist & Internet-arkitekt
  * Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20101227/dfe1f147/attachment.pgp>