[Build-common-hackers] Bug#568611: shogun: please allow 'debian/rules clean' as non-rooth

[Jonathan Nieder]

Hi CDBS hackers,

I submitted this enhancement idea earlier today, but failed to CC
you.  Thoughts?

Jonathan Nieder wrote:
> Soeren Sonnenburg wrote:
>> On Fri, 2010-02-05 at 23:04 -0600, Jonathan Nieder wrote:

>>>  $ debian/rules clean
>>>  test -x debian/rules
>>>  dh_testroot
>>>  dh_testroot: You must run this as root (or use fakeroot).
>>>  make: *** [testroot] Error 255
>>> 
>>> This test seems a little over-strict: the worst thing that could
>>> happen from a 'clean' as non-root would be a different error causing
>>> it not to finish the job, and if lucky (e.g. if the user was using
>>> fakeroot or had not run any targets as root yet), the 'clean' will
>>> just work.
>>> 
>>> What do you think?  If you think this is a good idea, please reassign
>>> the bug to the relevant package.  I’m pretty sure it is not shogun but
>>> my cdbs-fu is not strong enough to pinpoint the problem.
>>
>> it is cdbs that is requiring this... why don't you use
>> fakeroot ./debian/rules clean?
>
> I do, but I shouldn’t need to. :)
>
> Thanks,
> Jonathan