[Build-common-hackers] Bug#573350: Bug#573350: cdbs: autotools-vars.mk shouldn't include makefile.mk

Emilio Pozuelo Monfort pochu at debian.org
Wed Mar 10 22:10:37 UTC 2010


On 10/03/10 20:43, Jonas Smedegaard wrote:
> I am curious both how you implemented your class (maybe you took care of
> some parts that I missed out?)

Yes. Your class doesn't build for several python versions, doesn't take care of
-dbg packages, and doesn't integrate with pysupport/pycentral.

> and also I wonder why it fails with the
> current class hierarchy.

Because I run ./configure, make and make install (and possibly make check) for
every supported python version and for a normal and a -dbg package (if it
exists), so makefile.mk is useless (actually harmful) to me... At least the way
I've implemented it (which is very similar to pygobject's debian/rules).

> So... Would you mind sharing that class of yours?

Sure.

> I have wondered myself why autotools-vars included makefile and not just
> makefile-vars.  It was done like that before I got heavily involved with
> CDBS, but I suspect it was due to order of inclusion - which I believe
> has been solved since then.
> 
> Nevertheless there might be users reying on that dependency by now :-/

Another option would be to move the autotools vars to autotools-realvars.mk
(heh) and include it from autotools-vars.mk, so that one can include
autotools-realvars.mk to only get the autotools variables and not makefile.mk
and so that we don't break compatibility.

> So please, share your code and let's see what is the problem there -
> perhaps it can enlighten me of some common problem that others might run
> into which is relevant to fix, even if your class might not be needed
> now that there's an alternative implementation available.

I've attached it. It's not finished as you can see by the multiple FIXMEs ;) but
I've already built pygobject and pygtk using it (I'm attaching their rules.old
and rules.new so that you get a feeling).

Cheers,
Emilio
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pygobject.rules.new
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20100310/927dddd6/attachment.asc>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pygobject.rules.old
Type: application/x-trash
Size: 5369 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20100310/927dddd6/attachment-0002.old>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pygtk.rules.new
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20100310/927dddd6/attachment-0001.asc>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pygtk.rules.old
Type: application/x-trash
Size: 7221 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20100310/927dddd6/attachment-0003.old>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: python-autotools.mk
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20100310/927dddd6/attachment-0002.asc>


More information about the Build-common-hackers mailing list